Red Hat Bugzilla – Bug 501433
Review Request: perl-DateTime-Calendar-Mayan - Mayan Long Count Calendar
Last modified: 2010-07-21 01:07:53 EDT
Spec URL: http://fedorapeople.org/~cweyl/review/perl-DateTime-Calendar-Mayan.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-DateTime-Calendar-Mayan-0.0601-1.fc10.src.rpm Description: An implementation of the Mayan Long Count, Haab, and Tzolkin calendars as defined in "Calendrical Calculations The Millennium Edition". Supplemented by "Frequently Asked Questions about Calendars". Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1362528 Additional Comment: This is a new (optional) testing dependency of Moose 0.79. *rt-0.10
Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1362528 + rpmlint is silent for SRPM and for RPM. + source files match upstream url b64421ef42d3b2c7852a09887057e54e17c748a9 DateTime-Calendar-Mayan-0.0601.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=10, Tests=124, 3 wallclock secs ( 0.10 usr 0.03 sys + 2.57 cusr 0.19 csys = 2.89 CPU) + Package perl-DateTime-Calendar-Mayan-0.0601-1.fc12.noarch => Provides: perl(DateTime::Calendar::Mayan) = 0.0601 Requires: perl(DateTime) perl(Params::Validate) perl(constant) perl(strict) perl(vars) + Not a GUI application APPROVED.
New Package CVS Request ======================= Package Name: perl-DateTime-Calendar-Mayan Short Description: Mayan Long Count Calendar Owners: cweyl Branches: F-9 F-10 F-11 devel InitialCC: perl-sig
cvs done.
Thanks for the review! :-)
Package Change Request ====================== Package Name: perl-DateTime-Calendar-Mayan New Branches: EL-6 Owners: tremble cweyl has previously expressed that he is happy for others to request EPEL branches
CVS done (by process-cvs-requests.py).