Red Hat Bugzilla – Bug 501566
Review Request: python-repoze-who-friendlyform - Collection of repoze.who friendly form plugins
Last modified: 2009-05-28 04:15:29 EDT
Spec URL: http://www.auroralinux.org/people/spot/review/new/python-repoze-who-friendlyform.spec
SRPM URL: http://www.auroralinux.org/people/spot/review/new/python-repoze-who-friendlyform-1.0-0.1.b3.fc11.src.rpm
repoze.who-friendlyform is a repoze.who plugin which provides a collection of
developer-friendly form plugins.
[pass] source files match upstream:
[pass] package meets naming and versioning guidelines.
[pass] specfile is properly named, is cleanly written and uses macros consistently.
[pass] dist tag is present.
[pass] build root is correct.
is the recommended value, but not the only one)
[pass] license field matches the actual license.
[pass] license is open source-compatible.
[pass]latest version is being packaged.
[pass] BuildRequires are proper.
[pass] compiler flags are appropriate.
[pass] %clean is present.
[pass] package installs properly.
(it appears to, although I do not have a very good test case)
[pass]rpmlint is silent.
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
[pass] final provides and requires are sane:
provides python-repoze-who-friendlyform = 1.0-0.1.b3.fc10
python(abi) = 2.5
python-repoze-who >= 1.0
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PartialHardlinkSets) <= 4.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
[?]%check is present and all tests pass:
# Tests fail?
# PYTHONPATH=$(pwd) nosetests
what do these comments mean? do the tests fail, if so why?
[pass]owns the directories it creates.
[pass]doesn't own any directories it shouldn't.
[pass]no duplicates in %files.
[pass]file permissions are appropriate.
[pass] code, not content.
[pass] documentation is small, so no -docs subpackage is necessary.
[pass] %docs are not necessary for the proper functioning of the package.
[pass not a GUI app]desktop files valid and installed properly.
This gets my approval, if you do not see the %check section as a problem. This should be clarified in the comment as to what is going on. This was not built in mock as python-repoze-who has not made its way into the repos yet.
A fair amount of the repoze stack has failing tests, even though we know the code works fine, which is why it is commented out.
New Package CVS Request
Package Name: python-repoze-who-friendlyform
Short Description: Collection of repoze.who friendly form plugins
Branches: EL-5 F-10 F-11 devel
... and it's done.
python-repoze-who-friendlyform-1.0-0.1.b3.fc10 has been submitted as an update for Fedora 10.
python-repoze-who-friendlyform-1.0-0.1.b3.fc11 has been submitted as an update for Fedora 11.
python-repoze-who-friendlyform-1.0-0.1.b3.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
python-repoze-who-friendlyform-1.0-0.1.b3.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.