Description of problem: `/etc/init.d/puppet status` doesn't work Version-Release number of selected component (if applicable): 0.24.8-1.1 How reproducible: always Steps to Reproduce: Run `/etc/init.d/puppet status` Actual results: pidof: invalid options on command line! pidof: invalid options on command line! -p is stopped Expected results: puppetd (pid 1286) is running... or puppetd is stopped Additional info: The error occurs because RHEL4 doesn't support the -p option in the status function used by the init script. The status function is defined in /etc/rc.d/init.d/functions. RHEL5 does support -p. I attached a patch which fixes the problem. It should only be applied to the RHEL4 package.
Created attachment 344673 [details] remove '-p' option from status function
Confirmed, working on this rightaway
Created attachment 344904 [details] Check that status accepts a -p option before using it FWIW, this was caused by upstream commit 7f5ded18 (Fixed #1646 - service puppet status does not work as non-root on redhat system). http://github.com/reductivelabs/puppet/commit/7f5ded185269cabeb7921c4f4739e1f66a34d54d http://projects.reductivelabs.com/issues/show/1646 We can tease lutter about not testing that upstream patch well enough. ;) Ideally, the init script can be made to test whether status has the -p option, so that it works on older EL releases, as well as newer EL and Fedora. Perhaps the attached patch isn't too ugly to be used and submitted upstream?
Nice patch, +1 to have this go upstream
I submitted this to puppet-dev today. I'll assign this to me so I remember to update/close it when we have a fixed package.
Upstream bug URL http://projects.reductivelabs.com/issues/2123
puppet-0.24.8-4.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/puppet-0.24.8-4.fc10
puppet-0.24.8-4.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/puppet-0.24.8-4.el5
puppet-0.24.8-4.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/puppet-0.24.8-4.fc11
puppet-0.24.8-4.el4 has been submitted as an update for Fedora EPEL 4. http://admin.fedoraproject.org/updates/puppet-0.24.8-4.el4
puppet-0.24.8-4.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update puppet'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2009-0262
puppet-0.24.8-4.el4 has been pushed to the Fedora EPEL 4 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update puppet'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-4/FEDORA-EPEL-2009-0253
puppet-0.24.8-4.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update puppet'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-8477
puppet-0.24.8-4.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update puppet'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-8494
puppet-0.24.8-4.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
puppet-0.24.8-4.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
puppet-0.24.8-4.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.
puppet-0.24.8-4.el4 has been pushed to the Fedora EPEL 4 stable repository. If problems still persist, please make note of it in this bug report.