Spec URL: http://people.redhat.com/dmalcolm/python/python-testosterone.spec SRPM URL: http://people.redhat.com/dmalcolm/python/python-testosterone-0.4.1-1.src.rpm Description: Testosterone is a curses-based interface for running python tests written with the PyUnit testing framework (aka unittest in the standard library). Scratch build in Koji here: http://koji.fedoraproject.org/koji/taskinfo?taskID=1367313
Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1367313 + rpmlint is silent for SRPM and for RPM. + source files match upstream url b9566d407696277b272e7bc76c66c498415e0a4b testosterone-0.4.1.tgz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI application Suggestions: 1) You should contact upstream to add license text in tarball or in source files 2) you should use %global instead of %define in SPEC file. APPROVED.
New Package CVS Request ======================= Package Name: python-testosterone Short Description: Text-based UI for running Python unit tests Owners: dmalcolm Branches: InitialCC:
CVS done (no release branches were requested, so there's only a devel branch).
Thanks. Imported into CVS (devel) and built into dist-f12 as http://koji.fedoraproject.org/koji/taskinfo?taskID=1378455