Spec URL: http://fedorapeople.org/~cweyl/review/perl-Class-DBI-Plugin-DeepAbstractSearch.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-Class-DBI-Plugin-DeepAbstractSearch-0.08-1.fc10.src.rpm Description: This plugin provides a SQL::Abstract search method for Class::DBI. It is similar to Class::DBI::AbstractSearch, but allows you to search and sort by fields from joined tables. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1373749 Additional Comment: This is a new optional testing dep of DBIx::Class. *rt-0.10
Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1373749 + rpmlint is silent for SRPM and for RPM. + source files match upstream url a81ed8446fb4c990211e203b08f98f472cb83774 Class-DBI-Plugin-DeepAbstractSearch-0.08.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=1, Tests=0, 0 wallclock secs ( 0.04 usr 0.01 sys + 0.03 cusr 0.01 csys = 0.09 CPU) + Package perl-Class-DBI-Plugin-DeepAbstractSearch-0.08-1.fc12.noarch => Provides: perl(Class::DBI::Plugin::DeepAbstractSearch) = 0.08 Requires: perl(SQL::Abstract) perl(base) perl(strict) perl(warnings) + Not a GUI application APPROVED.
New Package CVS Request ======================= Package Name: perl-Class-DBI-Plugin-DeepAbstractSearch Short Description: SQL::Abstract for Class::DBI Owners: cweyl Branches: F-9 F-10 F-11 devel InitialCC: perl-sig
CVS done.
Thanks for the review! :-)
Package Change Request ====================== Package Name: perl-Class-DBI-Plugin-DeepAbstractSearch New Branches: el6 Owners: iarnell tremble
Git done (by process-git-requests).