Red Hat Bugzilla – Bug 502622
Review Request: perl-Config-Properties - Read and write property files
Last modified: 2009-06-15 22:35:37 EDT
Spec URL: http://www.bachelot.org/fedora/SPECS/perl-Config-Properties.spec SRPM URL: http://www.bachelot.org/fedora/SRPMS/perl-Config-Properties-1.70-1.fc10.src.rpm Description: Config::Properties is a near implementation of the java.util.Properties API. It is designed to allow easy reading, writing and manipulation of Java- style property files.
Builds fine; rpmlint is silent. FYI, I agree that conditionally running a test depending on the name of the user running it is dumb and needs to be patched out. I can see why this would require Test::More at runtime. It doesn't appear anywhere in the final package (save the Changelog, where it talks about the test suite). * source files match upstream. sha256sum: afb0e7a20a95f0e8004296fdecd1c320ec7d296cbdb5ce7bbc0a1f75266d7e84 Config-Properties-1.70.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. ? final provides and requires are sane: perl(Config::Properties) = 1.70 perl-Config-Properties = 1.70-1.fc11 = perl(:MODULE_COMPAT_5.10.0) perl(Carp) perl(IO::Handle) ? perl(Test::More) perl(strict) perl(warnings) * %check is present and all tests pass: All tests successful. Files=7, Tests=52, 1 wallclock secs ( 0.05 usr 0.02 sys + 0.31 cusr 0.07 csys = 0.45 CPU) * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package.
Thanks for the review Tibbs. New version, fixesthe useless Requires : Spec URL: http://www.bachelot.org/fedora/SPECS/perl-Config-Properties.spec SRPM URL: http://www.bachelot.org/fedora/SRPMS/perl-Config-Properties-1.70-2.fc10.src.rpm
Looks good. APPROVED
New Package CVS Request ======================= Package Name: perl-Config-Properties Short Description: Read and write property files Owners: xavierb Branches: F-10 F-11 EL-5 InitialCC: perl-sig
CVS done.
perl-Config-Properties-1.70-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/perl-Config-Properties-1.70-2.fc10
perl-Config-Properties-1.70-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-Config-Properties-1.70-2.fc11
perl-Config-Properties-1.70-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
perl-Config-Properties-1.70-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.