Spec URL: http://kwizart.fedorapeople.org/review/mingw32-dirac.spec SRPM URL: http://kwizart.fedorapeople.org/review/mingw32-dirac-1.0.2-1.fc10.src.rpm Description: MinGW Windows dirac compression library
This package doesn't compile on my Fedora 11 environment using rpmbuild: libtool: link: i686-pc-mingw32-g++ -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions --param=ssp-buffer-size=4 -mms-bitfields -o .libs/RGBtoYUV411.exe RGBtoYUV411.o common/libconv_common.a ../../libdirac_common/.libs/libdirac_common.a libtool: link: i686-pc-mingw32-g++ -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions --param=ssp-buffer-size=4 -mms-bitfields -o .libs/RGBtoYUV420.exe RGBtoYUV420.o common/libconv_common.a ../../libdirac_common/.libs/libdirac_common.a common/libconv_common.a(setstdiomode.o):/home/erik/rpmbuild/BUILD/dirac-1.0.2/util/conversion/common/setstdiomode.cpp:62: undefined reference to `__imp___ZN8dirac_vu4_iobE' common/libconv_common.a(setstdiomode.o):/home/erik/rpmbuild/BUILD/dirac-1.0.2/util/conversion/common/setstdiomode.cpp:54: undefined reference to `__imp___ZN8dirac_vu4_iobE' collect2: ld returned 1 exit status make[3]: *** [RGBtoYUV420.exe] Error 1 make[3]: *** Waiting for unfinished jobs.... common/libconv_common.a(setstdiomode.o):/home/erik/rpmbuild/BUILD/dirac-1.0.2/util/conversion/common/setstdiomode.cpp:62: undefined reference to `__imp___ZN8dirac_vu4_iobE' common/libconv_common.a(setstdiomode.o):/home/erik/rpmbuild/BUILD/dirac-1.0.2/util/conversion/common/setstdiomode.cpp:54: undefined reference to `__imp___ZN8dirac_vu4_iobE' collect2: ld returned 1 exit status make[3]: *** [RGBtoYUV411.exe] Error 1 make[3]: Leaving directory `/home/erik/rpmbuild/BUILD/dirac-1.0.2/util/conversion'
It worked with F-10 mingw32 but not anymore with F-11 and later: This problem is about binary mode with win32 executable, but I'm only interested in the libraries which built cannot be splitted easily from the executable. Spec URL: http://kwizart.fedorapeople.org/SPECS/mingw32-dirac.spec SRPM URL: http://kwizart.fedorapeople.org/SRPMS/mingw32-dirac-1.0.2-2.fc11.src.rpm Description: MinGW Windows dirac compression library
I'm trying to take care of the oldest of the review tickets; I had to learn about mingw32 before I could look at this. Outside of the spec having several bits which are unnecessary with modern Fedora (BuildRoot:, cleaning of buildroot in %install, the entire %clean section) which you can remove if you like, this package looks fine. * source files match upstream. sha256sum: 816b16f18d235ff8ccd40d95fc5b4fad61ae47583e86607932929d70bf1f00fd dirac-1.0.2.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * license field matches the actual license. * license is open source-compatible. * license text included in package. * version packaged is the same as the native Fedora version. * package is noarch. * BuildRequires are proper. * compiler flags are appropriate. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * special mingw32 dependency generators are used. * final provides and requires are sane: mingw32(libdirac_decoder-0.dll) mingw32(libdirac_encoder-0.dll) mingw32-dirac = 1.0.2-2.fc15 = mingw32-filesystem >= 62 mingw32-runtime mingw32(kernel32.dll) mingw32(libdirac_decoder-0.dll) mingw32(libdirac_encoder-0.dll) mingw32(libgcc_s_sjlj-1.dll) mingw32(libstdc++-6.dll) mingw32(msvcrt.dll) * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no static libraries. * .dll and .def files in _mingw32_bindir * .dll.a and .la files in _mingw32_libdir * dll files are listed explicitly in %files. * libraries and executables are stripped properly. APPROVED
New Package SCM Request ======================= Package Name: mingw32-dirac Short Description: MinGW Windows dirac compression library Owners: kwizart Branches: el5 el6 f13 f14 InitialCC: fedora-mingw.org Thx for the review.
InitialCC cannot be an email address; it must be a user or a defined group. I do not believe there's a group defined for mingw. Also, that isn't even the address of the mingw list (which is mingw.org).
New Package SCM Request ======================= Package Name: mingw32-dirac Short Description: MinGW Windows dirac compression library Owners: kwizart Branches: el5 el6 f13 f14 InitialCC:
Git done (by process-git-requests).