Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
For bugs related to Red Hat Enterprise Linux 5 product line. The current stable release is 5.10. For Red Hat Enterprise Linux 6 and above, please visit Red Hat JIRA https://issues.redhat.com/secure/CreateIssue!default.jspa?pid=12332745 to report new issues.

Bug 502909

Summary: [QLogic 5.4 bug] qlge breaks PPC
Product: Red Hat Enterprise Linux 5 Reporter: Ameet Paranjape <aparanja>
Component: kernelAssignee: Marcus Barrow <mbarrow>
Status: CLOSED NOTABUG QA Contact: Red Hat Kernel QE team <kernel-qe>
Severity: high Docs Contact:
Priority: high    
Version: 5.4CC: andrew.vasquez, andriusb, aparanja, coughlan, jjarvis, lwang, peterm, rlary, ying.lok
Target Milestone: rcKeywords: OtherQA
Target Release: 5.4   
Hardware: ppc64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-07-16 13:07:38 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 479288    
Bug Blocks: 460170    
Attachments:
Description Flags
handle 64k page size none

Description Ameet Paranjape 2009-05-27 17:52:46 UTC
Description of problem:

From the RKML mailing list.  The latest version of the patch posted for Red Hat Bugzilla bug 479288 breaks IBM PowerPC.

> > +#define TX_DESC_PER_IOCB 8
> > +/* The maximum number of frags we handle is based
> > + * on PAGE_SIZE...
> > + */
> > +#if (PAGE_SHIFT == 12) || (PAGE_SHIFT == 13)	/* 4k & 8k pages */  <----here
> > +#define TX_DESC_PER_OAL ((MAX_SKB_FRAGS - TX_DESC_PER_IOCB) + 2)
> > +#else /* all other page sizes */
> > +#define TX_DESC_PER_OAL 0
> > +#endif

This needs to support 64K page sizes.

Please contact aparanja for any additional information.

Comment 1 Andrius Benokraitis 2009-07-09 14:29:56 UTC
Marcus - was this covered by another BZ?

Comment 4 Andrius Benokraitis 2009-07-14 13:03:53 UTC
Marcus - is this issue covered by another BZ? I see there are other ppc EEH issues still pending. Thank you!

Comment 5 Andrius Benokraitis 2009-07-14 13:06:25 UTC
More specifically, is bug 511141 the bug that should be tracking this?

Comment 6 Marcus Barrow 2009-07-16 03:51:00 UTC
Created attachment 353943 [details]
handle 64k page size


Allocate the same way for 4k, 8k and now 64k pages...

Comment 7 Marcus Barrow 2009-07-16 13:07:38 UTC
This patch is not required. The array of structures being allocated is being used for information that does not fit within a single page. With the 64k page size this is not an issue.