Red Hat Bugzilla – Bug 502909
[QLogic 5.4 bug] qlge breaks PPC
Last modified: 2013-03-07 19:56:46 EST
Description of problem:
From the RKML mailing list. The latest version of the patch posted for Red Hat Bugzilla bug 479288 breaks IBM PowerPC.
> > +#define TX_DESC_PER_IOCB 8
> > +/* The maximum number of frags we handle is based
> > + * on PAGE_SIZE...
> > + */
> > +#if (PAGE_SHIFT == 12) || (PAGE_SHIFT == 13) /* 4k & 8k pages */ <----here
> > +#define TX_DESC_PER_OAL ((MAX_SKB_FRAGS - TX_DESC_PER_IOCB) + 2)
> > +#else /* all other page sizes */
> > +#define TX_DESC_PER_OAL 0
> > +#endif
This needs to support 64K page sizes.
Please contact firstname.lastname@example.org for any additional information.
Marcus - was this covered by another BZ?
Marcus - is this issue covered by another BZ? I see there are other ppc EEH issues still pending. Thank you!
More specifically, is bug 511141 the bug that should be tracking this?
Created attachment 353943 [details]
handle 64k page size
Allocate the same way for 4k, 8k and now 64k pages...
This patch is not required. The array of structures being allocated is being used for information that does not fit within a single page. With the 64k page size this is not an issue.