Spec URL: http://people.freedesktop.org/~david/eggdbus.spec SRPM URL: http://people.freedesktop.org/~david/eggdbus-0.4-1.src.rpm Description: Experimental D-Bus bindings for GObject
Missing BuildRequires: gtk-doc -%{_datadir}/man/* +%{_datadir}/man/man1/* perhaps Group: Development/Libraries for lack of anything better URL: http://cgit.freedesktop.org/~david/eggdbus -make +make %{?_smp_mflags}
and one more thing -%configure --enable-gtk-doc +%configure --enable-gtk-doc --disable-static which spares few cycles and allows removing rm -f $RPM_BUILD_ROOT%{_libdir}/*.a
Yeah, I've noticed the same things. Please provide a spec that fixes those, then I'll run down the checklist.
Created attachment 345761 [details] new spec file Here is a new spec file that I am going to base my review on.
With that spec file, packages build fine in mock, and rpmlint reports: [mclasen@planemask rpmbuild]$ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm 4 packages and 0 specfiles checked; 0 errors, 0 warnings.
doing the checklist: rpmlint: ok, see above package name: ok spec file name: ok packaging guidelines: ok license: ok license field: ok license file: ok spec file language: ok spec legible: ok upstream sources: ok buildable: ok excludearch: n/a build deps: ok locales: n/a shared libs: ok relocatable: n/a directory ownership: -devel needs to depend on gtk-doc for /usr/share/gtk-doc duplicate files: ok permissions: ok %clean: ok macro use: ok content: ok doc subpackage: ok doc content: ok headers: ok static libs: n/a pc files: ok shared libs: ok devel deps: ok libtool archives: ok gui apps: n/a file ownership: -devel must not include /usr/share/gtk-doc/html, it should just include /usr/share/gtk-doc/html/eggdbus %install: ok utf8 filenames: ok
Also, I just noticed that the package installs two documentation trees: /usr/share/gtk-doc/html/eggdbus /usr/share/gtk-doc/html/tests the second name looks awfully general. That should probably be fixed, or that part of the docs nuked.
Created attachment 345768 [details] new spec file This spec file addresses the remaining concerns. If you are ok with the changes made, this can be approved.
Looks good to me. Thanks.
ok, approved.
New Package CVS Request ======================= Package Name: eggdbus Short Description: Experimenal D-Bus bindings for GObject Owners: davidz Branches: InitialCC:
CVS done.
packages have been built