Spec URL: http://ispbrasil.com.br/sk1/sk1.spec SRPM URL: http://ispbrasil.com.br/sk1/sk1-0.9.1pre_rev730-1.fc11.src.rpm Description: illustration program similar to corel draw or adobe illustrator ------------------- koji scratch build http://koji.fedoraproject.org/koji/taskinfo?taskID=1380257
I'm sure that proper versioning scheme is Version: 0.9.1 Release: 0.1.pre_rev730%{?dist}
And why not to keep sK1 as Name of the package?
oh...crap. i didn't realize someone else had done this :(. here's my take: https://bugzilla.redhat.com/show_bug.cgi?id=503616 i did say on the list i'd do this one...sigh. peter: I think we try to avoid unnecessary capitalization, right? that's why I used sk1.
*** Bug 503616 has been marked as a duplicate of this bug. ***
I'll review it.
Some notes: * As I already said - versioning is bad. See above. * COPYRIGHTS, GNU_GPL_v2, GNU_LGPL_v2 should be added to %doc Please, update your srpm.
(In reply to comment #3) > peter: I think we try to avoid unnecessary capitalization, right? that's why I > used sk1. According to name guidelines, package should be called after how upstream call the project, and they call it "sK1". https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Case_Sensitivity
done. http://ispbrasil.com.br/sk1/sK1.spec http://ispbrasil.com.br/sk1/sK1-0.9.1-0.1.pre_rev730.fc11.src.rpm ----------------------- koji scratch build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=1439391
Notes: * Wrong category for desktop-file-install. It should be "Graphics" instead of "Development". Easy to fix. * Since it provides skencil and sketch, I suggest you to add "Obsoletes" for sketch as well. However, I'm not sure about it, since I cannot remember, did sketch was included in Fedora or not. Anyway, here is my REVIEW: - rpmlint is not silent: [petro@Workplace Desktop]$ rpmlint sK1-0.9.1-0.1.pre_rev730.fc12.i586.rpm sK1.i586: E: non-executable-script /usr/lib/python2.6/site-packages/sk1/__init__.py 0644 1 packages and 0 specfiles checked; 1 errors, 0 warnings. [petro@Workplace Desktop]$ This file contains shebang, and therefore rpmlint thinks of its as a script. Easyfix. + The package is named according to the Package Naming Guidelines. + The spec file name matches the base package %{name}, in the format %{name}.spec. + The package meets the Packaging Guidelines. + The package is licensed with a Fedora approved license and meets the Licensing Guidelines . + The License field in the package spec file matches the actual license. + The files, containing the text of the license(s) for the package, are included in %doc. + The spec file is written in American English. + The spec file for the package is legible (as usual for python apps and libraries). +/- The sources used to build the package matches the upstream source, as provided in the spec URL. Unfortunately, your URL is wrong. Please fix it [petro@Sulaco SOURCES]$ sha256sum sk1-0.9.1pre_rev730.tar.gz* 56d4b58d30b52e97dccb81ce157e41c2b6b5f0c0c383b0f4c55bacb317443c84 sk1-0.9.1pre_rev730.tar.gz 56d4b58d30b52e97dccb81ce157e41c2b6b5f0c0c383b0f4c55bacb317443c84 sk1-0.9.1pre_rev730.tar.gz.1 [petro@Sulaco SOURCES]$ + The package successfully compiles and builds into binary rpms on at least one primary architecture. See koji link above. + All build dependencies are listed in BuildRequires. + The package owns all directories that it creates. + The package does not list a file more than once in the spec file's %files listings. + Permissions on files are set properly. + The package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + The package consistently uses macros. + The package contains code, or permissible content. + No extra large documentation files. + Everything, the package includes as %doc, does not affect the runtime of the application. + The package includes a %{name}.desktop file, and that file is properly installed with desktop-file-install in the %install section. + The package does not own files or directories already owned by other packages. + At the beginning of %install, the package runs rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + All filenames in rpm packages are valid UTF-8. Please fix mentioned issues.
please look again http://ispbrasil.com.br/sk1/sK1.spec http://ispbrasil.com.br/sk1/sK1-0.9.1-0.1.pre_rev730.fc11.src.rpm http://koji.fedoraproject.org/koji/taskinfo?taskID=1443019
Ok, all issues were fixed. This package is APPROVED.
New Package CVS Request ======================= Package Name: sK1 Short Description: illustration program similar to corel draw or adobe illustrator Owners: itamarjp Branches: F-10 F-11 InitialCC:
Please check if the description is ok. I believe that using registered trade names is not allowed......
New Package CVS Request ======================= Package Name: sK1 Short Description: open-source illustration program Owners: itamarjp Branches: F-10 F-11 InitialCC:
CVS done. Note that I created the package as you requested, "sK1" with a capital K, but I'm not really sure that's what you intended.
sK1-0.9.1-0.1.pre_rev730.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/sK1-0.9.1-0.1.pre_rev730.fc11
sK1-0.9.1-0.1.pre_rev730.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/sK1-0.9.1-0.1.pre_rev730.fc10
sK1-0.9.1-0.1.pre_rev730.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
sK1-0.9.1-0.1.pre_rev730.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.