Bug 502956 - libvirt needs to support kvm-img or qemu-img
Summary: libvirt needs to support kvm-img or qemu-img
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Virtualization Tools
Classification: Community
Component: libvirt
Version: unspecified
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Daniel Veillard
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-05-27 22:25 UTC by Doug Goldstein
Modified: 2010-03-16 17:20 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2009-07-30 11:43:13 UTC
Embargoed:


Attachments (Terms of Use)
libvirt-0.6.3-kvm-img.patch (9.57 KB, patch)
2009-05-27 22:25 UTC, Doug Goldstein
no flags Details | Diff

Description Doug Goldstein 2009-05-27 22:25:35 UTC
Created attachment 345686 [details]
libvirt-0.6.3-kvm-img.patch

Description of problem:

This bug is a clone of #502896 but for libvirt. I've refactored the entire section to become run-time dependant instead of build-time. The logic is that on certain distros, you can add and remove support for QEMU, KVM, and Xen at any point.

If the patch needs to be tweaked in anyway, let me know.

Comment 1 Daniel Veillard 2009-05-28 08:42:28 UTC
Sorry this seems to be a request for a libvirt change upstream,
and the best way to handle this is to communicate about the issue and
send the patch to the mailing-list, see 

  https://www.redhat.com/mailman/listinfo/libvir-list

There are non Red Hat people who are checking patches on the list but
are unlikely to check bugs here, so the best way to get upstream patches
discussed and applied is really to go on the list,

 thanks !

Daniel

Comment 2 Doug Goldstein 2009-05-28 13:25:52 UTC
http://www.libvirt.org states that any bug reports should be filed here exactly as I did.

Seeing as you also are upstream for libvirt, can you please update the website to state the correct place to file bugs then.

Comment 3 Mark McLoughlin 2009-05-28 13:45:45 UTC
(In reply to comment #2)
> http://www.libvirt.org states that any bug reports should be filed here exactly
> as I did.

You're absolutely correct, but I think DV is just saying that if you actually have a patch it's better to (also?) post it to libvir-list.

Comment 4 Daniel Veillard 2009-05-29 08:00:33 UTC
Yes, plus it's more than merely a bug fix, it's a behaviour change,
and really best discussed on-list (I'm not against it, just want things
to be discussed in the proper location)

Daniel

Comment 5 Daniel Berrangé 2009-05-29 09:16:31 UTC
Now upstream

http://www.redhat.com/archives/libvir-list/2009-May/msg00583.html

Comment 6 Daniel Berrangé 2009-07-30 11:43:13 UTC
Merged upstream

commit abed6fca87a901d6e4bbb2cb8d22270db00d26e7
Author: Daniel Veillard <veillard>
Date:   Thu Jun 11 13:18:56 2009 +0000

    find and use kvm-img, qemu-img or qcow-create dynamically
    * configure.in src/libvirt_private.syms src/storage_backend_fs.c
      src/util.c src/util.h: find and use kvm-img, qemu-img or qcow-create
      dynamically at runtime, patch by Doug Goldstein
    * AUTHORS: add Doug Goldstein


Will be available in 0.7.0 release


Note You need to log in before you can comment on or make changes to this bug.