Spec URL: http://wiki.open.hr/~zpintar/fedora-11/SPECS/easystroke.spec SRPM URL: http://wiki.open.hr/~zpintar/fedora-11/SRPMS/easystroke-0.4.4-1.fc11.src.rpm Description: Easystroke is a gesture-recognition application for X11. Gestures or strokes are movements that you make with you mouse (or your pen, finger etc.) while holding down a specific mouse button. Easystroke will execute certain actions if it recognizes the stroke; currently easystroke can emulate key presses, execute shell commands, hold down modifiers and emulate a scroll wheel. rpmlint is not clean for debug package: easystroke-debuginfo.x86_64: E: empty-debuginfo-package I checked if %{optflags} passing to compiler, and they pass (see build.log at Koji), but I'm still getting this error. Koji builds: http://koji.fedoraproject.org/koji/taskinfo?taskID=1381241 http://koji.fedoraproject.org/koji/taskinfo?taskID=1381227
you may want to path Makefile and remove -s in install command install -Ds $(BINARY) $(DESTDIR)$(BINDIR)/$(BINARY) to install -D $(BINARY) $(DESTDIR)$(BINDIR)/$(BINARY)
Thanks. I resolved, now it's good. Spec URL: http://wiki.open.hr/~zpintar/fedora-11/SPECS/easystroke.spec SRPM URL: http://wiki.open.hr/~zpintar/fedora-11/SRPMS/easystroke-0.4.4-2.fc11.src.rpm
Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1386455 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 4b196b07524f55422c64113aee1a5bcbbf249ee9 easystroke-0.4.4.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + translations are available. + Does owns the directories it creates. + gtk-update-icon-cache scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Desktop file installed correctly. + GUI application Suggestions: 1) I don't see mimetype written in desktop file so according to https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database, drop update-desktop-database from SPEC. 2) I think you should own only svg file and add Requires: hicolor-icon-theme and change in %files as %{_datadir}/icons/hicolor/scalable/apps/easystroke.svg
done. Spec URL: http://wiki.open.hr/~zpintar/fedora-11/SPECS/easystroke.spec SRPM URL: http://wiki.open.hr/~zpintar/fedora-11/SRPMS/easystroke-0.4.4-3.fc11.src.rpm We do not need this: Requires: hicolor-icon-theme I built some packages witohut that and nobody compliant (include my sponsor ;) )
you can find packages requiring hicolor-icon-theme using repoquery -q --whatrequires hicolor-icon-theme But, anyway hicolor-icon-theme is in the dependency chain, don't add it. APPROVED.
Thank you for review. New Package CVS Request ======================= Package Name: easystroke Short Description: Gesture-recognition application for X11 Owners: grof Branches: F9 F10 F11 InitialCC: grof
Please note branch names are "F-9", "F-10", "F-11". CVS done.
I have problem with build under F-9: ----------------------------------------------- g++ -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -o easystroke actiondb.o actions.o annotate.o composite.o dbus-server.o fire.o gesture.o grabber.o main.o prefdb.o prefs.o shape.o stats.o util.o water.o win.o stroke.o gui.o desktop.o version.o -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -lboost_serialization -lXtst `pkg-config gtkmm-2.4 dbus-glib-1 --libs` stroke.o: In function `stroke_compare': /builddir/build/BUILD/easystroke-0.4.4/stroke.c:191: undefined reference to `step.3612' /builddir/build/BUILD/easystroke-0.4.4/stroke.c:199: undefined reference to `step.3612' /builddir/build/BUILD/easystroke-0.4.4/stroke.c:187: undefined reference to `step.3612' /builddir/build/BUILD/easystroke-0.4.4/stroke.c:195: undefined reference to `step.3612' collect2: ld returned 1 exit status make: *** [easystroke] Error 1 ------------------------------------------------ Any idea how resolving this?
easystroke-0.4.4-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/easystroke-0.4.4-3.fc10
easystroke-0.4.4-3.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/easystroke-0.4.4-3.fc11
(In reply to comment #8) > I have problem with build under F-9: > > ----------------------------------------------- > g++ -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector > --param=ssp-buffer-size=4 -m64 -mtune=generic -o easystroke actiondb.o > actions.o annotate.o composite.o dbus-server.o fire.o gesture.o grabber.o > main.o prefdb.o prefs.o shape.o stats.o util.o water.o win.o stroke.o gui.o > desktop.o version.o -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions > -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic > -lboost_serialization -lXtst `pkg-config gtkmm-2.4 dbus-glib-1 --libs` > stroke.o: In function `stroke_compare': > /builddir/build/BUILD/easystroke-0.4.4/stroke.c:191: undefined reference to > `step.3612' > /builddir/build/BUILD/easystroke-0.4.4/stroke.c:199: undefined reference to > `step.3612' > /builddir/build/BUILD/easystroke-0.4.4/stroke.c:187: undefined reference to > `step.3612' > /builddir/build/BUILD/easystroke-0.4.4/stroke.c:195: undefined reference to > `step.3612' > collect2: ld returned 1 exit status > make: *** [easystroke] Error 1 > ------------------------------------------------ > > Any idea how resolving this? Not sure what's happening here. Also having no F9 installed machine now.
(In reply to comment #11) > > Any idea how resolving this? > > Not sure what's happening here. Also having no F9 installed machine now. Never mind, if I'll not resolve that, then nothing of F-9 branch (for a couple of days it will be obsolete)
Created attachment 346390 [details] Patch to compile on F-9 - Well, maybe gcc 4.3.0 (used in F-9) does not support nested inline functions. I tried to change to use non-inline nested function instead of nested inline function (in stroke.c) and it succeeds: http://koji.fedoraproject.org/koji/taskinfo?taskID=1391017 What is strange is that F-10 uses gcc 4.3.2 and with it build seems to succeed... - By the way Fedora specific compilation flags are not correctly honored. E.g. from http://kojipkgs.fedoraproject.org/packages/easystroke/0.4.4/3.fc12/data/logs/i586/ --------------------------------------------------------------- 78 cc -c -o gui.o gui.c 85 cc -c -o desktop.o desktop.c ---------------------------------------------------------------
make %{?_smp_mflags} CXX="g++ %{optflags}" CC="gcc -std=c99 %{optflags}" can be a workaround.
OK, thanks. I'll resolve this and make new release of package.
Thanks mtasaka for helping here. aah! my eyes missed gui.c and desktop.c compilation lines.
easystroke-0.4.5-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/easystroke-0.4.5-1.fc10
easystroke-0.4.5-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/easystroke-0.4.5-1.fc11
easystroke-0.4.5-1.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/easystroke-0.4.5-1.fc9
I updated all packages (btw new version is on upstream, so I included it) Closing now. Thanks to Tasaka, too.
easystroke-0.4.5-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
easystroke-0.4.5-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
easystroke-0.4.5-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.