Spec URL: http://nucleo.fedorapeople.org/pkg-reviews/webkitkde/webkitkde.spec SRPM URL: http://nucleo.fedorapeople.org/pkg-reviews/webkitkde/webkitkde-0.0.1-0.1.20090530svn.fc11.src.rpm Description: This project aims to integrate WebKit (QtWebKit) into KDE. The project is made up of the following components: - WebKitKDE: The binding between KDE and QtWebKit - WebKitPart: A KPart based on it Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1385155
$ rpmlint webkitkde-0.0.1-0.1.20090530svn.fc11.src.rpm webkitkde-0.0.1-0.1.20090530svn.fc11.i586.rpm webkitkde-debuginfo-0.0.1-0.1.20090530svn.fc11.i586.rpm webkitkde-devel-0.0.1-0.1.20090530svn.fc11.i586.rpm webkitpart-0.0.1-0.1.20090530svn.fc11.i586.rpm webkitpart-devel-0.0.1-0.1.20090530svn.fc11.i586.rpm 6 packages and 0 specfiles checked; 0 errors, 0 warnings.
New scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1385199
New Spec URL: http://nucleo.fedorapeople.org/pkg-reviews/webkitkde/webkitkde.spec New SRPM URL: http://nucleo.fedorapeople.org/pkg-reviews/webkitkde/webkitkde-0.0.1-0.1.20090914svn.fc11.src.rpm New scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1675784 $ rpmlint webkitkde-0.0.1-0.1.20090914svn.fc11.i586.rpm webkitkde-0.0.1-0.1.20090914svn.fc11.src.rpm webkitkde-debuginfo-0.0.1-0.1.20090914svn.fc11.i586.rpm webkitkde-devel-0.0.1-0.1.20090914svn.fc11.i586.rpm webkitpart-0.0.1-0.1.20090914svn.fc11.i586.rpm webkitpart-devel-0.0.1-0.1.20090914svn.fc11.i586.rpm 6 packages and 0 specfiles checked; 0 errors, 0 warnings.
I can take a look.
$ rpmlint *.rpm x86_64/*.rpm 6 packages and 0 specfiles checked; 0 errors, 0 warnings. Looks good, only a couple of very small nitpicks 1. the locale files look like they belong in the main webkitkde pkg 2. webkitkde-devel probabaly should Requires: kdelibs4-devel 3. %install could use make install/fast ... 4. leave out the "If WebKit does not show up in Konqueror, run 'kbuildsycoca4'. comments, shouldn't be needed But I won't consider any of these review blockers, but please address them prior to building. Otherwise, Source is documented scriptlets good macro usage consistent (could use %%_kde4_appsdir} tested to function APPROVED.
(In reply to comment #5) I have made all changes 1-4 and use %{_kde4_appsdir} now. Also I have build rpm with the latest svn snapshot that adds possibility to display SSL information. New Spec URL: http://nucleo.fedorapeople.org/pkg-reviews/webkitkde/webkitkde.spec New SRPM URL: http://nucleo.fedorapeople.org/pkg-reviews/webkitkde/webkitkde-0.0.1-0.1.20090924svn.fc11.src.rpm rpmlint still shows 0 errors, 0 warnings (In reply to comment #5) > Source is documented > scriptlets good > macro usage consistent (could use %%_kde4_appsdir} > tested to function > > APPROVED. Thank you, Rex for review. New Package CVS Request ======================= Package Name: webkitkde Short Description: QtWebKit bindings to KDE Owners: nucleo rdieter Branches: F-10 F-11 InitialCC:
cvs done.
webkitkde-0.0.1-0.1.20090924svn.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/webkitkde-0.0.1-0.1.20090924svn.fc10
webkitkde-0.0.1-0.1.20090924svn.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/webkitkde-0.0.1-0.1.20090924svn.fc11
webkitkde-0.0.1-0.2.20090924svn.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/webkitkde-0.0.1-0.2.20090924svn.fc10
webkitkde-0.0.1-0.2.20090924svn.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/webkitkde-0.0.1-0.2.20090924svn.fc11
webkitkde-0.0.1-0.2.20090924svn.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update webkitkde'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-9976
webkitkde-0.0.1-0.2.20090924svn.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update webkitkde'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-10070
webkitkde-0.0.1-0.2.20090924svn.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
webkitkde-0.0.1-0.2.20090924svn.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.