+ koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1388894
+ rpmlint is silent
- seems /usr/share/fonts/saab is created twice so remove following line from SPEC
%dir %{_fontdir}
+ verified upstream source as
aa8a32819d51b701a1d45a674d17432937f06ac3  saab.0.91.zip
+ Otherwise following fonts packaging guidelines.

Should:
1) SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. 


APPROVED.

Thanks

New Package CVS Request
=======================
Package Name: saab-fonts
Short Description: Punjabi OTF fonts
Owners: aalam
Branches: F-11
InitialCC: fonts-sig

CVS done.

Thanks a lot.
Package is build for devel and F-11. It is available on koji.

Thanks a lot.
Package is build for devel and F-11. It is available on koji.
http://koji.fedoraproject.org/koji/packageinfo?packageID=8550

I'm a bit late but anyway:

1.  adding a fontconfig file to the package would be nice so it's substituted correctly

2. it would have been nicer to name the font guca-saab-fonts as per guidelines. If guca ever publishes another font the package will need to be renamed (not a blocker in the meanwhile)

I have update SPEC file as well fontconfig file.
SPEC file:
http://aalam.fedorapeople.org/punjabi-fonts/saab/saab-fonts.spec
SRPM:
http://aalam.fedorapeople.org/punjabi-fonts/saab/saab-fonts-0.91-2.fc11.src.rpm

Can you please check whether it will work or not?
Thanks

(In reply to comment #8)

> Can you please check whether it will work or not?

1. Unless saab is derived from lohit punjabi and they have the same look and metrics I'd really not include

  <alias binding="same">
    <family>Lohit Punjabi</family>
    <accept>
      <family>Saab</family>
    </accept>
  </alias>

2. The 90 priority is safe, but very conservative. I'd discuss with the Lohit people and i18n if Saab could not be bumped a little.

3. Please cc the fonts list on fonts review so the right people get cc-ed

4. Please also check you didn't miss any step in
http://fedoraproject.org/wiki/Font_package_lifecycle

thanks Nicolas for your reply. I will check what you have asked above.

Lohit Punjabi and Saab font are different fonts. What benefits will be after bumping conf file priority to 91?

so new conf file will be
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE fontconfig SYSTEM "../fonts.dtd">
<fontconfig>
  <alias>
    <family>sans-serif</family>
    <prefer>
      <family>Saab</family>
    </prefer>
  </alias>
  <alias>
    <family>Saab</family>
    <default>
      <family>serif</family>
    </default>
  </alias>
</fontconfig>

Just discussed with nim-nim. Please use 66 as priority for fontconfig file.

Hi,
  You can use following SRPM to update fontconfig file in cvs.
http://paragn.fedorapeople.org/saab-fonts-0.91-3.fc12.src.rpm

Build for Rawhide. Closing Bug