Spec URL: http://fedorapeople.org/~cweyl/review/perl-DBICx-TestDatabase.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-DBICx-TestDatabase-0.02-1.fc10.src.rpm Description: This module creates a temporary SQLite database, deploys your DBIC schema, and then connects to it. This lets you easily test your DBIC schema. Since you have a fresh database for every test, you don't have to worry about cleaning up after your tests, ordering of tests affecting failure, etc. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1390363 Additional Comment: This is a new testing BR of DBIx::Class::DateTime::Epoch. *rt-0.10
Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1390363 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 16935864a5ef035a506c1a03537540b79afa3b70 DBICx-TestDatabase-0.02.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=3, Tests=13, 1 wallclock secs ( 0.03 usr 0.01 sys + 0.47 cusr 0.06 csys = 0.57 CPU) + Package perl-DBICx-TestDatabase-0.02-1.fc12.noarch => Provides: perl(DBICx::TestDatabase) = 0.02 perl(DBICx::TestDatabase::Subclass) Requires: perl(File::Temp) perl(strict) perl(warnings) + Not a GUI application APPROVED.
New Package CVS Request ======================= Package Name: perl-DBICx-TestDatabase Short Description: Create a temporary database from a DBIx::Class::Schema Owners: cweyl Branches: F-9 F-10 F-11 devel InitialCC: perl-sig
CVS done.
Thanks for the review! :-)