Spec URL: http://fedorapeople.org/~cweyl/review/perl-Time-Warp.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-Time-Warp-0.5-1.fc10.src.rpm Description: Our external experience unfolds in 3 1/2 dimensions (time has a dimensionality of 1/2). The Time::Warp module offers developers control over the measurement of time. This module is redundant if you're from Gallifrey, and not recommended for use at high speeds near very massive objects. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1390415 Additional Comment: This is a BR of a new testing BR of DBIx::Class::DateTime::Epoch. *rt-0.10
Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1390415 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 0fd3e16c80a41228364d08978cc45b6391c7d02d Time-Warp-0.5.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=1, Tests=8, 2 wallclock secs ( 0.02 usr 0.01 sys + 0.01 cusr 0.01 csys = 0.05 CPU) + Package perl-Time-Warp-0.5-1.fc12.i586 => Provides: perl(Time::Warp) = 0.5 Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) perl(DynaLoader) perl(Exporter) perl(strict) perl(vars) rpmlib(VersionedDependencies) <= 3.0.3-1 rtld(GNU_HASH) + Not a GUI application APPROVED.
New Package CVS Request ======================= Package Name: perl-Time-Warp Short Description: Change the start and speed of Event time Owners: cweyl Branches: F-9 F-10 F-11 devel InitialCC: perl-sig
CVS done.
Thanks for the review! :-)