Bug 504243 - Review Request: php-getid3 - The PHP media file parser
Review Request: php-getid3 - The PHP media file parser
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
low Severity medium
: ---
: ---
Assigned To: David Nalley
Fedora Extras Quality Assurance
Depends On:
  Show dependency treegraph
Reported: 2009-06-04 19:24 EDT by Paulo Roma Cavalcanti
Modified: 2014-10-27 07:58 EDT (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2010-02-16 03:56:52 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
david: fedora‑review+
limburgher: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description Paulo Roma Cavalcanti 2009-06-04 19:24:00 EDT
Description of problem:

Spec URL: http://orion.lcg.ufrj.br/RPMS/SPECS/php-getid3.spec


getID3() is a PHP script that extracts useful information
(such as ID3 tags, bitrate, playtime, etc.) from MP3s &
other multimedia file formats (Ogg, WMA, WMV, ASF, WAV, AVI,
AAC, VQF, FLAC, MusePack, Real, QuickTime, Monkey's Audio, MIDI and more).


This package is used by some web applications, such as ampache,
which is under review.
Comment 1 David Nalley 2009-06-04 21:32:26 EDT
I'll try and get this done by tomorrow.
Comment 2 Paulo Roma Cavalcanti 2009-06-04 22:11:02 EDT

ampache is using the beta version, 2.0.0b4.

Therefore, I also packaged 2.0.0b5.

Comment 3 David Nalley 2009-06-09 14:57:36 EDT
Sorry, several things cropped up to slow me down on this, I intended to have this done many days ago. 

OK: rpmlint must be run on every package. The output should be posted in the review.

[ke4qqq@nalleyt61 rpmbuild]$ rpmlint RPMS/noarch/php-getid3-1.7.9-1.fc11.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[ke4qqq@nalleyt61 rpmbuild]$ rpmlint SRPMS/php-getid3-1.7.9-1.fc11.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[ke4qqq@nalleyt61 rpmbuild]$ rpmlint SPECS/php-getid3.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

[ke4qqq@nalleyt61 SPECS]$ rpmlint ../SRPMS/php-getid3-2.0.0b5-1.fc11.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[ke4qqq@nalleyt61 SPECS]$ rpmlint php-getid3.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
[ke4qqq@nalleyt61 SPECS]$ rpmlint ../RPMS/noarch/php-getid3-2.0.0b5-1.fc11.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. 
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines .
On the website, gplv2 is specified as the license. License.txt included in source also agrees with gplv2 

OK: The License field in the package spec file must match the actual license.
OK: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc
OK: The spec file must be written in American English.
OK: The spec file for the package MUST be legible. 
OK: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines 

d2b24ccb4bd4a5c135517bd0ae3b2dd3  getid3-2.0.0b5.zip
d2b24ccb4bd4a5c135517bd0ae3b2dd3  getid3-2.0.0b5.zip.1

OK: The package MUST successfully compile and build into binary rpms on at least one primary architecture. 
Really no compile or build, php does runtime compilatoins. 
NA: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line. 
OK: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense.
N/A: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
N/A: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. 
N/A: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker. 
OK: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. 
OK: A Fedora package must not list a file more than once in the spec file's %files listings. 
OK: Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line. 
OK: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). 
OK: Each package must consistently use macros. 
OK: The package must contain code, or permissable content. 
N/A: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity). 
OK: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. 
N/A: Header files must be in a -devel package. 
NA: Static libraries must be in a -static package. 
NA: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for directory ownership and usability). 
NA: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. 
NA: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} 
NA: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built.
NA: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation. 
OK: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time. 
OK: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). 
OK: All filenames in rpm packages must be valid UTF-8. 

Comment 4 Paulo Roma Cavalcanti 2009-06-09 15:46:09 EDT
New Package CVS Request
Package Name: php-getid3
Short Description: The PHP media file parser
Owners: roma
Branches: F-9 F-10 F-11
InitialCC: roma

Thanks, David.
Comment 5 Kevin Fenzi 2009-06-10 00:51:26 EDT
cvs done except for the F-9 branch. We are no longer doing F-9 branches.
Comment 6 David Nalley 2009-07-16 01:08:13 EDT

What's the status on this?
Comment 7 Paulo Roma Cavalcanti 2010-02-16 03:56:52 EST
This package has been built a long time ago.

I am, therefore, closing this bug.
Comment 8 Paulo Roma Cavalcanti 2012-10-08 10:56:52 EDT
New Package CVS Request
Package Name: php-getid3
Short Description: The PHP media file parser
Owners: roma
Branches: EL-5 EL-6
InitialCC: roma
Comment 9 Jason Tibbitts 2012-10-08 12:20:13 EDT
The package is already in the repository.  If you want additional branches, please file a change request.
Comment 10 Paulo Roma Cavalcanti 2012-10-08 12:27:09 EDT
Package Change Request
Package Name: php-getid3
New Branches: el5 el6
Owners: roma
InitialCC: roma
Comment 11 Jason Tibbitts 2012-10-08 12:38:46 EDT
Git done (by process-git-requests).
Comment 12 Remi Collet 2014-10-26 03:59:51 EDT
I'm not the owner of this package, and like to avoid the unresponsive maintainer process.

Bug #1147802 is open for 4 weeks without answer
Direct mail to the owner, without answer, for 
Package Change Request ~2 weeks


Package Name: php-getid3
New Branches: epel7
Owners: remi
Comment 13 Paulo Roma Cavalcanti 2014-10-26 13:38:49 EDT
You are not the owner of the package, 
nor epel7 is a priority.

We are still in Fedora, right.
You better take a shower and calm down...
Comment 14 Gwyn Ciesla 2014-10-27 07:58:31 EDT
Git done (by process-git-requests).

Note You need to log in before you can comment on or make changes to this bug.