SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-syntax.spec SRPM: http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-syntax-1.0.0-1.fc11.src.rpm Description: Syntax is a lexical analysis framework. It supports pluggable syntax modules, and comes with modules for Ruby, XML, and YAML.
Attempted to incorporate comments from here: https://bugzilla.redhat.com/show_bug.cgi?id=504469#c1 SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-syntax.spec SRPM: http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-syntax-1.0.0-2.fc11.src.rpm
MUST: rpmlint must be run on every package. 1] rpmlint complaining rubygem-syntax.noarch: E: non-executable-script /usr/lib/ruby/gems/1.8/gems/syntax-1.0.0/test/ALL-TESTS.rb 0644 MUST: The package must be named according to the Package Naming Guidelines - OK MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. - OK, rubygem package MUST: The package must meet the Packaging Guidelines - OK, meets packaging guidelines and ruby specific packaging guidelines MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines - OK, public domain MUST: The License field in the package spec file must match the actual license. - OK, attached LICENSE file MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. - OK MUST: The spec file must be written in American English. - OK MUST: The spec file for the package MUST be legible. - OK MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. - OK MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. - OK, http://koji.fedoraproject.org/koji/taskinfo?taskID=1439866 MUST: If the package does not successfully compile, build or work on an architecture - OK, noarch package, builded ok MUST: All build dependencies must be listed in BuildRequires - OK MUST: The spec file MUST handle locales properly. - OK, no locales available MUST: Every binary RPM package (or subpackage) which stores shared library - OK, no shared library MUST: If the package is designed to be relocatable - OK MUST: A package must own all directories that it creates. - OK MUST: A Fedora package must not list a file more than once in the spec file's %files listings. - OK MUST: Permissions on files must be set properly. - OK MUST: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). - OK MUST: Each package must consistently use macros. - OK MUST: The package must contain code, or permissable content. - OK MUST: Large documentation files must go in a -doc subpackage. - OK, no large documentation MUST: If a package includes something as %doc, it must not affect the runtime of the application. - OK MUST: Header files must be in a -devel package. - OK, no header files MUST: Static libraries must be in a -static package. - OK, no static libraries MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for directory ownership and usability). - OK, no .pc files MUST: If a package contains library files with a suffix ... - OK MUST: In the vast majority of cases, devel packages must require the base package - OK, no -devel package MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. - OK MUST: Packages containing GUI applications must include a %{name}.desktop file, - OK, no gui MUST: Packages must not own files or directories already owned by other packages. - OK MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). - OK MUST: All filenames in rpm packages must be valid UTF-8. -OK TODO: rpmlint
(In reply to comment #2) > MUST: rpmlint must be run on every package. > 1] rpmlint complaining > rubygem-syntax.noarch: E: non-executable-script > /usr/lib/ruby/gems/1.8/gems/syntax-1.0.0/test/ALL-TESTS.rb 0644 > TODO: > rpmlint This is not in the path that could contain executable scripts, and is not meant to be executable by user of the package. It's probably not worth removing the shebang.
ok, approved
New Package CVS Request ======================= Package Name: rubygem-syntax Short Description: Ruby library for performing simple syntax highlighting Owners: lkundrak Branches: F-11 EL-5
CVS done.
Thanks for the review! Imported and built.
*** Bug 562992 has been marked as a duplicate of this bug. ***