Bug 504474 - Review Request: rubygem-rack-test - Simple testing API built on Rack
Summary: Review Request: rubygem-rack-test - Simple testing API built on Rack
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Mamoru TASAKA
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 504471
TreeView+ depends on / blocked
 
Reported: 2009-06-07 11:44 UTC by Lubomir Rintel
Modified: 2009-07-10 09:02 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2009-07-10 09:02:24 UTC
Type: ---
Embargoed:
mtasaka: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Lubomir Rintel 2009-06-07 11:44:49 UTC
SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-rack-test.spec
SRPM: http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-rack-test-0.3.0-1.fc11.src.rpm

Description:

Rack::Test is a small, simple testing API for Rack apps. It can be used on its
own or as a reusable starting point for Web frameworks and testing libraries
to build on. Most of its initial functionality is an extraction of Merb 1.0's
request helpers feature.

Comment 3 Mamoru TASAKA 2009-06-28 16:06:27 UTC
Basically okay, however 0.4.0 is released on 2009-06-25.
Would you upgrade this srpm?

Comment 5 Mamoru TASAKA 2009-06-30 16:01:29 UTC
Well,
- I have overlooked it, however it seems this package should have
  "Requires: rubygem(rack)" because lib/rack/test.rb contains:
--------------------------------------------------------------
     5  require "uri"
     6  require "rack"
--------------------------------------------------------------
  (although Rakefile does not suggest such dependency). Would
  you check this?

Comment 6 Lubomir Rintel 2009-07-08 15:55:39 UTC
Right, though there's little chance anyone would test a rack application w/o having rack installed. I've updated the package:

SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-rack-test.spec
SRPM:
http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-rack-test-0.4.0-2.fc11.src.rpm

Comment 7 Mamoru TASAKA 2009-07-08 16:41:32 UTC
Okay.

---------------------------------------------------------------
    This package (rubygem-rack-test) is APPROVED by mtasaka
---------------------------------------------------------------

Comment 8 Lubomir Rintel 2009-07-08 17:10:14 UTC
Thanks for the review.

New Package CVS Request
=======================
Package Name: rubygem-rack-test
Short Description: Simple testing API built on Rack
Owners: lkundrak
Branches: F-10 F-11 EL-5

Comment 9 Jason Tibbitts 2009-07-10 03:34:12 UTC
CVS done.

Comment 10 Lubomir Rintel 2009-07-10 09:02:24 UTC
Thanks for the review.

Imported and built.


Note You need to log in before you can comment on or make changes to this bug.