Spec URL: http://fedorapeople.org/~cweyl/review/perl-SQL-Shell.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-SQL-Shell-1.14-1.fc10.src.rpm Description: SQL::Shell is a command-interpreter API for building shells and batch scripts. A command-line interface with readline support is included as part of the CPAN distribution. See <SQL::Shell::Manual> for a user guide. SQL::Shell offers features similar to the mysql or sql*plus client programs but is database independent. This package provides the backend SQL::Shell libraries. For the command-line interperter (sqlsh), please also install the sqlsh package. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1397935 *rt-0.10
Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1397935 + rpmlint is silent for SRPM and for RPM. + source files match upstream url a313e85c6e22eda8d8df1fdb835e5437ddab6225 SQL-Shell-1.14.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=3, Tests=31, 1 wallclock secs ( 0.03 usr 0.00 sys + 0.35 cusr 0.04 csys = 0.42 CPU) + Package perl-SQL-Shell-1.14-1.fc12.noarch => Provides: perl(SQL::Shell) = 1.14 perl(SQL::Shell::Manual) = 1.6 perl(Tie::Rowset::InMemory) Requires: perl(Carp) perl(DBI) perl(File::Path) perl(IO::File) perl(URI::Escape) perl(constant) perl(strict) perl(vars) + Not a GUI application Should 1) Add following for subpackage sqlsh %defattr(-,root,root,-) APPROVED.
New Package CVS Request ======================= Package Name: perl-SQL-Shell Short Description: Command interpreter for DBI shells Owners: cweyl Branches: F-9 F-10 F-11 devel InitialCC: perl-sig
CVS done.
(In reply to comment #1) > Should > 1) Add following for subpackage sqlsh > %defattr(-,root,root,-) Done. Thanks! :)
Thanks for the review! :-)