Spec URL: http://fedorapeople.org/~cweyl/review/perl-Linux-Inotify2.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-Linux-Inotify2-1.2-1.fc10.src.rpm Description: This module implements an interface to the Linux 2.6.13+ Inotify file/directory change notification sytem. It has a number of advantages over the Linux::Inotify module: - it is portable (Linux::Inotify only works on x86) - the equivalent of fullname works correctly - it is better documented - it has callback-style interface, which is better suited for integration. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1398272 Additional Comment: This is a requirement of a new BR of the latest GA Catalyst::Devel. *rt-0.10
Review: + package builds in mock (rawhide i586). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1398272 + rpmlint is silent for SRPM and for RPM. + source files match upstream url a4c62821471692abe60e8e91602b6b3bf140616c Linux-Inotify2-1.2.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=2, Tests=6, 0 wallclock secs ( 0.02 usr 0.01 sys + 0.04 cusr 0.01 csys = 0.08 CPU) + Package perl-Linux-Inotify2-1.2-1.fc12.i586 => Provides: perl(Linux::Inotify2) = 1.2 perl(Linux::Inotify2::Event) perl(Linux::Inotify2::Watch) Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.4) perl(base) perl(Carp) perl(Fcntl) perl(Scalar::Util) rpmlib(VersionedDependencies) <= 3.0.3-1 rtld(GNU_HASH) + Not a GUI application Should: 1) Ask upstream to add perl license text in source files itself as we don't count license information based on COPYING file. APPROVED.
New Package CVS Request ======================= Package Name: perl-Linux-Inotify2 Short Description: Scalable directory/file change notification Owners: cweyl Branches: F-9 F-10 F-11 devel InitialCC: perl-sig
CVS done.
Thanks for the review! :-)
Package Change Request ====================== Package Name: perl-Linux-Inotify2 New Branches: el6 Owners: iarnell tremble InitialCC: perl-sig
Git done (by process-git-requests).