Description of problem:

The init script for httpd relies on the presence of the pid file for stop, reload and condrestart.

However, the pid file location can be changed in httpd.conf or even not specified at all which would break the script.

The location of the pid file can be specified by setting PIDFILE in "/etc/sysconfig/httpd", but that will not work if no PidFile option is set in httpd.conf (ie no pidfile at all)

Version-Release number of selected component (if applicable):

httpd-2.2.3-22.el5_3.1

How reproducible:

100% reproducible

Steps to Reproduce:

1. Stop Apache
   # service httpd stop
   Stopping httpd:                                            [  OK  ]

2. Comment out PidFile in /etc/httpd/conf/httpd.conf
   # PidFile run/httpd.pid
   
3. Start Apache
   # service httpd start
   Starting httpd:                                            [  OK  ]

4. Use condrestart
   # service httpd condrestart
   => Nothing happens

Actual results:

  Nothing, Apache is not restarted

Expected result:

  Stopping httpd:                                            [  OK  ]
  Starting httpd:                                            [  OK  ]
      
Additional info:

The fix for bug #491135 makes the matter actually worse:

1. Upgrade to httpd-2.2.3-27.el5 which includes the fix for bug #491135

2. Start Apache
   # service httpd start
   Starting httpd:                                            [  OK  ]

3. Check if it's running:
   # service httpd status
   httpd dead but subsys locked

4. Use condrestart
   # service httpd condrestart
   => Nothing happens

5. Stop Apache
   # service httpd stop
   Stopping httpd:                                            [FAILED]
   
6. Start Apache again:
   service httpd start
   Starting httpd: (98)Address already in use: make_sock: could not bind to address 0.0.0.0:80
   no listening sockets available, shutting down
   Unable to open logs
                                                           [FAILED]


Our customer suggests using lockfile instead of pidfile, by testing for the existence of the lockfile in stop, reload and in condrestart as follow. Yet, if the script cannot find the pidfile (PidFile not specified in httpd.conf) then stop will not work with the patch from bug #491135.
  
  stop() {
        [ -f ${lockfile} ] || return;
        echo -n $"Stopping $prog: "
        killproc -d 10 $httpd
        RETVAL=$?
        echo
        [ $RETVAL = 0 ] && rm -f ${lockfile} ${pidfile}
  }
  reload() {
        [ -f ${lockfile} ] || return;
        echo -n $"Reloading $prog: "
        if ! LANG=$HTTPD_LANG $httpd $OPTIONS -t >&/dev/null; then
         RETVAL=$?
        echo $"not reloading due to configuration syntax error"
        failure $"not reloading $httpd due to configuration syntax error"
    else
        killproc $httpd -HUP
        RETVAL=$?
    fi
    echo
  ...

  # See how we were called.
  case "$1" in
  ...
  condrestart)
        if [ -f ${lockfile} ] ; then
                stop
                start
        fi
        ;;
  ...
  
So I do not think that would fix the problem with the init script stopping other httpd processes since it's not using the pidfile, which is the only way to identify reliably the pid of the httpd started by the script.

When no PidFile is specified in the httpd.conf, Apache will use the default hardcoded value which is in logs/

 #define DEFAULT_PIDLOG DEFAULT_REL_RUNTIMEDIR "/httpd.pid"
 
with 
 
 #define DEFAULT_REL_RUNTIMEDIR "logs"

Thus, if no PidFile is specified, the httpd.pid will be created in "/var/log/httpd/httpd.pid" by default while the init script looks for it in "/var/run/httpd.pid", causing the breakage.

One possibility could be to specify the default location of httpd.pid at compile time by setting DEFAULT_PIDLOG to /var/run/httpd.pid, in the spec file:

  CFLAGS="$RPM_OPT_FLAGS -DDEFAULT_PIDLOG=\\\"/var/run/httpd.pid\\\" -fno-strict-aliasing"
  
In that case it seems to work without a PidFile specified in httpd.conf:

  # service httpd status
  httpd is stopped
  # service httpd start
  Starting httpd:                                            [  OK  ]
  # service httpd status
  httpd (pid  19925) is running...
  # service httpd condrestart
  Stopping httpd:                                            [  OK  ]
  Starting httpd:                                            [  OK  ]
  # service httpd stop
  Stopping httpd:                                            [  OK  ]

And also when an alternate location is specified in both httpd.conf and in "/etc/sysconfig/httpd":

  $ grep -i pidfile /etc/sysconfig/httpd
  PIDFILE=/tmp/httpd.pid
  
  $ grep -i pidfile /etc/httpd/conf/httpd.conf
  PidFile /tmp/httpd.pid

  # service httpd status
  httpd is stopped
  #  service httpd start
  Starting httpd:                                            [  OK  ]
  # service httpd status
  httpd (pid  21372) is running...
  #  service httpd condrestart
  Stopping httpd:                                            [  OK  ]
  Starting httpd:                                            [  OK  ]
  # service httpd stop
  Stopping httpd:                                            [  OK  ]

So setting DEFAULT_PIDLOG to the correct location in the spec file seems to be an appropriate fix.