Bug 505138 - Review Request: trac-peerreview-plugin - Framework for realtime code review within Trac
Summary: Review Request: trac-peerreview-plugin - Framework for realtime code review w...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-06-10 19:22 UTC by Chitlesh GOORAH
Modified: 2009-06-18 20:15 UTC (History)
3 users (show)

Fixed In Version: 0.11-1.svn5357.fc11
Clone Of:
Environment:
Last Closed: 2009-06-16 01:38:02 UTC
Type: ---
Embargoed:
panemade: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Chitlesh GOORAH 2009-06-10 19:22:45 UTC
Spec URL: http://chitlesh.fedorapeople.org/RPMS/trac-peerreview-plugin.spec
SRPM URL: http://chitlesh.fedorapeople.org/RPMS/trac-peerreview-plugin-0.11-1.svn5357.fc11.src.rpm
Description:
A Distributed Peer-Review Plug-in for TRAC Project
Management System.

Comment 1 Parag AN(पराग) 2009-06-11 11:04:43 UTC
Review:
+ package builds in mock (rawhide i586).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1405028
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.

Should:
1) use %global instead %define

APPROVED.

Comment 2 Chitlesh GOORAH 2009-06-11 11:26:00 UTC
New Package CVS Request
=======================
Package Name: trac-peerreview-plugin 
Short Description: Framework for realtime code review within Trac
Owner chitlesh
Branches: F-11

Comment 3 Jason Tibbitts 2009-06-11 17:03:47 UTC
Please stick to the CVS request format; it saves manual work by your friendly CVS admin.

CVS done.

Comment 4 Fedora Update System 2009-06-16 01:37:58 UTC
trac-peerreview-plugin-0.11-1.svn5357.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 5 Chitlesh GOORAH 2009-06-17 21:05:42 UTC
Package Change Request
======================
Package Name: trac-peerreview-plugin
New Branches: EL-5
Owners: chitlesh

Comment 6 Jason Tibbitts 2009-06-18 20:15:46 UTC
CVS done.


Note You need to log in before you can comment on or make changes to this bug.