Bug 505293 - Review Request: kobo - python modules for tools development
Summary: Review Request: kobo - python modules for tools development
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Marcela Mašláňová
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-06-11 11:52 UTC by Daniel Mach
Modified: 2015-01-26 14:00 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-08-21 11:00:19 UTC
Type: ---
Embargoed:
mmaslano: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Daniel Mach 2009-06-11 11:52:08 UTC
Spec URL: http://dan.steadynet.org/kobo.spec
SRPM URL: http://dan.steadynet.org/kobo-0.1.0-1.el5.src.rpm
(both addresses are temporary, project will be hosted on fedorahosted.org)

Description: 
Kobo is set of python modules designed for rapid tools development.
It implements hub-worker-client architecture, plugins, enhanced option parser, etc...
It is originally an internal Red Hat project which is being opensourced.

Comment 1 Marcela Mašláňová 2009-06-11 12:03:29 UTC
OK rpmlint on every package.
OK name of package accords to the Naming Guidelines.
OK spec file name match the base package %{name}.
OK package meet the Packaging Guidelines.
OK package has a good license.
OK spec file is written in American English.
OK spec file for the package must be legible.
? The sources used to build the package must match the upstream source.
OK successful koji compilation.
   http://koji.fedoraproject.org/koji/taskinfo?taskID=1405135
OK correct BuildRequires, Requires.
OK proper use of %find_lang macro.
OK shared library must call ldconfig in %post and %postun.
OK relocatable package must state this fact.
OK package must own their directories.
OK permissions on files must be set properly.
OK %clean section with rm -rf %{buildroot}.
OK consistent use of macros.
OK package contains code, or permissable content.
OK large documentation go in a -doc subpackage.
OK %doc must not affect the runtime of the application.
OK header files must be in a -devel package.
OK static libraries must be in a -static package.
OK pkgconfig(.pc) files must 'Requires: pkgconfig'.
OK library files with a suffix (.so) must go in -devel.
OK usually devel packages must require the base package.
OK Remove .la libtool archives.
OK GUI applications must include a %{name}.desktop file.
OK %install section starts with rm -rf %{buildroot}.

Comment 2 Marcela Mašláňová 2009-06-11 12:05:27 UTC
You should provide the source code tar ball somewhere. Because a reviewer has to check ,if srpm has matching source with upstream source.

Comment 3 Daniel Mach 2009-06-11 12:09:36 UTC
I am the upstream, latest tarball is included in the srpm.
Package will be placed on fedorahosted.org as soon as I have the project created.
Can't we skip this item in the checklist?

Comment 4 Marcela Mašláňová 2009-06-11 12:10:23 UTC
ACCEPT

Comment 5 Daniel Mach 2009-06-11 12:21:08 UTC
New Package CVS Request
=======================
Package Name: kobo
Short Description: Python modules for tools development
Owners: dmach
Branches: F11
InitialCC:

Comment 6 Jason Tibbitts 2009-06-11 17:05:22 UTC
CVS done.

Comment 7 Daniel Mach 2009-07-23 07:21:17 UTC
Package Change Request
======================
Package Name: kobo
New Branches: EL-5
Owners: dmach

Comment 8 Jason Tibbitts 2009-07-23 16:47:36 UTC
CVS done.

Comment 9 Daniel Mach 2015-01-26 11:31:48 UTC
Package Change Request
======================
Package Name: kobo
New Branches: epel7
Owners: dmach

Comment 10 Gwyn Ciesla 2015-01-26 14:00:56 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.