Red Hat Bugzilla – Bug 50542
errors in error messages
Last modified: 2007-04-18 12:35:21 EDT
Description of Problem:
A recompilation of gdm from 'roswell' generates pretty well deserved
compiler complaints. I believe that attached patch is needed but
it should be reviewed by somebody more familiar with internals.
As an aside - replacing in gui/gdmlogin.c this:
gnome_dialog_grab_focus (GNOME_DIALOG (dialog), 0);
gtk_widget_grab_focus (GTK_WINDOW (dialog));
allows to compile this source with older libraries (like those included
in 7.1). Not sure if entirely correct but so far it works just fine. :-)
Maybe 'configure' could do that by itself?
Created attachment 25691 [details]
patch for printf argument problems in gdm-184.108.40.206
I believe gnome_dialog_grab_focus() grabs focus on the 0th button of the dialog,
not the dialog itself as with gtk_widget_grab_focus(). Grumble, this function
should NOT have been added to libgnomeui for exactly the reason you mention - it
looks like someone (I know who) snuck it in without a ChangeLog entry.
Patch looks great though. I am moving this bug upstream:
and closing it here.