Spec URL: http://oget.fedorapeople.org/review/bouncycastle-tsp.spec SRPM URL: http://oget.fedorapeople.org/review/bouncycastle-tsp-1.43-1.fc11.src.rpm Description: Bouncy Castle consists of a lightweight cryptography API and is a provider for the Java Cryptography Extension and the Java Cryptography Architecture. This library package offers additional classes, in particuar generators/processors for Time Stamp Protocol (TSP), for Bouncy Castle. This SPEC file is almost a carbon copy of bouncycastle-mail's SPEC file which is already in Fedora and this package is needed for updating itext to 2.1.6 rpmlint: bouncycastle-tsp.src:115: W: libdir-macro-in-noarch-package (main package) %{_libdir}/gcj/%{name} This can be ignored because, for the time being, we are not building the AOT bits for bouncycastle packages, and hence they are noarch, including this one. koji rawhide build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1419904
Well, * Misc cosmetic issue ------------------------------------------------ BuildRequires: bouncycastle == %{version} Requires: %{name} = %{version}-%{release} ------------------------------------------------ - Choose "==" or "=" (I think using "=" instead of "==" is more common) ! BR/Requires - bouncycastle-mail already has "R: bouncycastle = 1.43" and "R/BR: bouncycastle = 1.43" is redundant (however I won't oppose to write this explicitly) No review blockers ----------------------------------------------------------- This package (bouncycastle-tsp) is APPROVED by mtasaka -----------------------------------------------------------
Thanks a lot. I will clean those up. New Package CVS Request ======================= Package Name: bouncycastle-tsp Short Description: TSP libraries for Bouncy Castle Owners: oget Branches: F-10 F-11 InitialCC:
cvs done.
bouncycastle-tsp-1.43-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/bouncycastle-tsp-1.43-2.fc11
Now closing (it seems F-10 build needs bouncycastle update and I will leave it to you)
(In reply to comment #5) > Now closing (it seems F-10 build needs bouncycastle update and I will > leave it to you) Yes, I will do that if I get requests or when I have the energy, as it needs buildroot overrides etc. Thanks for the review!
bouncycastle-tsp-1.43-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.