Description of problem:

This server has a winsync agreement with an Active Directory Domain. After upgrading FDS to 1.2 we got this frequent crashes where the last message recorded in the FDS error log is "Failed to generate LM/NT hashes". Downgrading to FDS 1.1.3 doesn't trigger the crash (but that version of FDS has stability problems of its own).

Version-Release number of selected component (if applicable):

freeIPA 1.2.1
Fedora Directory Server 1.2

How reproducible:

Some password changes triggers the bug, some others no. I haven't been able to find the exact ldap modify operation that triggers the bug.

However, I've been able to find the actual part of the code which contains the bug:

in function encode_ntlm_keys in ipa_pwd_extop.c this is the problem part:

      inc = newPasswd;
      outc = ucs2Passwd;
      cs = iconv(cd, &inc, &il, &outc, &ol);
      if (cs == -1) {
            ret = -1;
            free(ucs2Passwd);
            iconv_close(cd);
            goto done;
      }