About the only comments I can make, since I really know nothing of cross-toolchain packages:

Nothing seems to own /usr/msp430/include.

msp430-binutils owns /usr/msp430, and /usr/msp430/lib, but this package doesn't have a dependency on msp430-binutils so those directories will be unowned.  If this package really isn't supposed to depend on msp430-binutils then you need to rethink which packages need to own which directories.

Hi Jason,

> Nothing seems to own /usr/msp430/include.

Yep, I think you're right.  It looks like this package should own that.  I'll resolve this soon.

> ... If this package really isn't supposed to depend on msp430-binutils then you need to rethink which packages need to own which directories. ...

This package depends on msp430-gcc, which depends on msp430-binutils.

R

Hey,

I've just updated this to own /usr/msp430/include:

Spec URL: http://users.ecs.soton.ac.uk/rds/rpm/mspgcc/msp430-libc.spec
SRPM URL: http://users.ecs.soton.ac.uk/rds/rpm/mspgcc/msp430-libc-0-2.20090620cvs.fc11.src.rpm

Rob

Patches are now upstream.  Reflected in this specfile:

Spec URL: http://users.ecs.soton.ac.uk/rds/rpm/mspgcc/msp430-libc.spec
SRPM URL: http://users.ecs.soton.ac.uk/rds/rpm/mspgcc/msp430-libc-0-3.20090726cvs.fc11.src.rpm

Rob

I'll try and review this today - sorry for the delay.

rpmlint output:

[steve@quoit ~]$ rpmlint ./msp430-libc.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

[steve@quoit ~]$ rpmlint ./msp430-libc-0-3.20090726cvs.fc11.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Package name: OK
Spec file name: OK
Packaging Guidelines:
Licensing Guidelines: OK
License matches spec file: OK
License not in upstream source: OK (but should request that upstream adds it)
Spec file in US English: OK
Spec file legible: OK
Sources match upstream: OK
Must build on one arch: OK
BuildRequires: OK
Locales: N/A
Dynamic Lib: N/A
Owns all created directories: OK
Files only listed once: OK
File permissions: OK
Consistent Macro use: OK
Contains code and permissible content: OK
Large doc files: OK (there are none)
Nothing in %doc is runtime: OK

Header files must be in a -devel package:
Static libraries must be in a -static package:
  - I assume these two only apply if the package is targetted at the installed platform and that this doesn't apply to cross-libraries & tools. It makes no sense to separate the headers from the library since both are always required to make use of this package. It makes no sense to name the library -static when msp430 only supports static libraries anyway.

pkgconfig: OK (No .pc files included)
Library files with .so suffix: OK (None included)
Must not contain .la files: OK (None included)
GUI Applications: N/A
Must not own files/directories owned by other packages: OK
Install removes build root: OK
Filenames are UTF-8: OK

... and now for the SHOULD items...

Package review SHOULD items:

License in upstream source: As above, that should be requested to be added
Translations of description & summary: No translations available - can we get those via Transifex I wonder? Not sure how we can arrange that for the spec file itself.
Mock build: Robert, have you already tried that? If so I'll take your word for it that it works.
Package functions: It is impossible to test all package functions without a huge test suite. I can see that the code looks sane and the only reason for non-functioning would be a broken compiler which is not an issue relating to this particular package. I have used certain functions from this library before and they have worked as expected.
Scriptlets: N/A
Subpackages: N/A
.pc files: N/A
File deps outside of certain directories: N/A

So I think we are most of the way there with this.

FYI: it builds on the Fedora buildsystem:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1762830

You can test this yourself with "koji build dist-f13 --scratch msp430-libc-0-3.20090726cvs.fc11.src.rpm"

Hi,

Sorry about the delay.  Yes, as Till says, it does build OK on koji.

So I think this means that this package has passed its review.

Cheers,

Rob

Yes, I agree.

New Package CVS Request
=======================
Package Name: msp430-libc
Short Description: C library for use with GCC on Texas Instruments MSP430 microcontrollers
Owners: rspanton
Branches: F-10 F-11 F-12
InitialCC:

cvs done.

msp430-libc-0-3.20090726cvs.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update msp430-libc'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2009-11662

msp430-libc-0-3.20090726cvs.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.