Red Hat Bugzilla – Bug 507260
Review Request: wordpress-mu-plugin-defaults - WordPress MU Plugin to set new blog default settings
Last modified: 2009-07-03 15:50:05 EDT
Spec URL: http://nb.fedorapeople.org/wordpress-mu-plugin-defaults.spec
SRPM URL: http://nb.fedorapeople.org/wordpress-mu-plugin-defaults-1.2.3-1.fc11.src.rpm
This package allows you to set various defaults to automatically apply to new blogs, such as the default theme, etc.
This package is built for use with WordPress MU (wordpress-mu), not regular
This is not found from wordpress.org so I did not follow the normal wordpress packaging guidelines regarding the name. I spoke to Ian Weller (the author of those guidelines) on IRC and he said just to make a comment in the spec file.
This is my first request and I am looking for a sponsor.
Koji scratch build is here:
My FAS username is nb
I still can't sponsor you but Toshio will on my recommendation, he says, so I guess I'll assign this to me.
- Check your %description, it's a bit messy.
Everything else looks good to me, and rpmlint is quiet. Full review after you fix the description.
== FULL REVIEW ==
[ OK ] specfiles match:
[ OK ] source files match upstream:
[ OK ] package meets naming and versioning guidelines.
[ OK ] spec is properly named, cleanly written, and uses macros consistently.
[ OK ] dist tag is present.
[ OK ] build root is correct.
[ OK ] license field matches the actual license.
[ OK ] license is open source-compatible.
[ N/A ] license text included in package.
License text not provided so not necessary to be in %doc
[ OK ] latest version is being packaged.
[ N/A ] BuildRequires are proper.
[ N/A ] compiler flags are appropriate.
[ OK ] %clean is present.
[ OK ] package builds in mock.
[ OK ] package installs properly.
[ N/A ] debuginfo package looks complete.
[FAILED] rpmlint is silent.
wordpress-mu-plugin-defaults.noarch: W: incoherent-version-in-changelog 1.2.3-1 ['1.2.3-2.fc11', '1.2.3-2']
You need to add a changelog entry for each update (including the
fix-the-description update). Add a changelog entry that you fixed the
changelog as well and bump it for me to approve this package.
[ OK ] final provides and requires are sane
[ N/A ] %check is present and all tests pass:
[ OK ] no shared libraries are added to the regular linker search paths.
[ OK ] owns the directories it creates.
[ OK ] doesn't own any directories it shouldn't.
[ OK ] no duplicates in %files.
[ OK ] file permissions are appropriate.
[ N/A ] scriptlets match those on ScriptletSnippets page.
[ OK ] code, not content.
[ OK ] documentation is small, so no -docs subpackage is necessary.
[ OK ] %docs are not necessary for the proper functioning of the package.
[ OK ] no headers.
[ OK ] no pkgconfig files.
[ OK ] no libtool .la droppings.
[ OK ] desktop files valid and installed properly.
Not approved, see above
This should fix the issue.
This package (wordpress-mu-plugin-defaults) is APPROVED by ianweller
(now we wait for toshio to sponsor you)
New Package CVS Request
Package Name: wordpress-mu-plugin-defaults
Short Description: Enables default settings for wordpress-mu blogs
Branches: F-10 F-11 EL-5
wordpress-mu-plugin-defaults-1.2.3-3.fc11 has been submitted as an update for Fedora 11.
wordpress-mu-plugin-defaults-1.2.3-3.fc10 has been submitted as an update for Fedora 10.
wordpress-mu-plugin-defaults-1.2.3-3.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
wordpress-mu-plugin-defaults-1.2.3-3.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.