Bug 507544 - Review Request: perl-Math-Curve-Hilbert - Perl Implementation of Hilberts space filling Curve
Summary: Review Request: perl-Math-Curve-Hilbert - Perl Implementation of Hilberts spa...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-06-23 09:23 UTC by Rasmus Ory Nielsen
Modified: 2009-08-15 11:23 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2009-08-15 11:23:54 UTC
Type: ---
Embargoed:
j: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Rasmus Ory Nielsen 2009-06-23 09:23:59 UTC
Spec URL: http://ron.fedorapeople.org/perl-Math-Curve-Hilbert.spec
SRPM URL: http://ron.fedorapeople.org/perl-Math-Curve-Hilbert-0.04-1.fc11.src.rpm
Description:
The Hilbert Curve module provides some useful functions using Hilberts Space-
filling Curve. This is handy for things like Dithering, Flattening n-
dimensional data, fractals - all kind of things really.

Comment 1 Rasmus Ory Nielsen 2009-06-24 07:39:36 UTC
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1433035

Comment 2 Jason Tibbitts 2009-06-27 07:04:17 UTC
Builds fine and rpmlint is silent.

I would suggest a tweaked %description with better grammar and capitalization:

The Hilbert curve module provides some useful functions using Hilberts space-
filling Curve. This is handy for things like dithering, flattening
n-dimensional data, fractals - all kinds of things really.

That's terribly minor, so you can fix it up if you like when you check in.

* source files match upstream.  sha256sum:
   455c2932e99a4b1609f5b17176b49a18e99fd8af06c76f161d5083d25b57d825  Math-Curve-
   Hilbert-0.04.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.                                                              
x description could use some minor tweaks.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   perl(Math::Curve::Hilbert) = 0.04
   perl-Math-Curve-Hilbert = 0.04-1.fc12
  =
   perl(:MODULE_COMPAT_5.10.0)
   perl(Data::Dumper)
   perl(strict)
   perl(vars)

* %check is present and all tests pass.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

The package review process needs reviewers!  If you haven't done any package
reviews recently, please consider doing one.

Comment 3 Rasmus Ory Nielsen 2009-06-29 17:27:44 UTC
Hi Jason,

Thank you for the review.
I will fix the %description field when I check the package in.

Best regards,
Rasmus

Comment 4 Jason Tibbitts 2009-07-08 18:43:02 UTC
Did you intend to make a CVS request so that you can get this checked in and built?  http://fedoraproject.org/wiki/CVS_admin_requests

Comment 5 Rasmus Ory Nielsen 2009-07-08 20:18:08 UTC
I apologize for my inactivity. Work has been taking up all my time lately.
But, I will try to get checked in tomorrow.

Comment 6 Jason Tibbitts 2009-07-09 15:48:03 UTC
That's fine; I just wanted to make sure you weren't having problems with the procedure.

Comment 7 Rasmus Ory Nielsen 2009-07-10 11:14:31 UTC
New Package CVS Request
=======================
Package Name: perl-Math-Curve-Hilbert
Short Description: Perl implementation of Hilberts space-filling curve
Owners: ron
Branches: F-10 F-11
InitialCC: perl-sig

Comment 8 Jason Tibbitts 2009-07-10 18:12:20 UTC
CVS done.

Comment 9 Rasmus Ory Nielsen 2009-07-10 21:44:40 UTC
Checked in and built on devel, F-10, F-11.
Thanks for the review.


Note You need to log in before you can comment on or make changes to this bug.