Bug 507643 - exception is raised in PK as get_role_localised_present_from_enum returns None not a string [NEEDINFO]
exception is raised in PK as get_role_localised_present_from_enum returns Non...
Product: Fedora
Classification: Fedora
Component: gnome-packagekit (Show other bugs)
All Linux
low Severity medium
: ---
: ---
Assigned To: Richard Hughes
Fedora Extras Quality Assurance
Depends On:
  Show dependency treegraph
Reported: 2009-06-23 11:36 EDT by Muayyad Alsadi
Modified: 2010-06-28 09:15 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2010-06-28 09:15:03 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
rhughes: needinfo? (alsadi)

Attachments (Terms of Use)

External Trackers
Tracker ID Priority Status Summary Last Updated
GNOME Desktop 587713 None None None Never

  None (edit)
Description Muayyad Alsadi 2009-06-23 11:36:23 EDT
Description of problem:
since PRESENT_ROLE is set to an empty hash get_role_localised_present_from_enum will always return None, which breaks self.set_title(role)

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:

import packagekit.gtkwidgets

Actual results:
Traceback (most recent call last):
  File "/opt/proj/occ/OjubaControlCenter/widgets.py", line 79, in __clicked
    try: r=_pk.install(self.__pkgs, True)
  File "/usr/lib/python2.6/site-packages/packagekit/gtkwidgets.py", line 637, in install
    ret = self._progress.run()
  File "/usr/lib/python2.6/site-packages/packagekit/gtkwidgets.py", line 336, in run
TypeError: GtkWindow.set_title() argument 1 must be string, not None

Expected results:
no error

Additional info:
I suggest that all such functions fall back to '' instead of None, like this

def get_role_localised_present_from_enum(enum):
   if PRESENT_ROLE.has_key(enum):
       return PRESENT_ROLE[enum]
       return ''
Comment 1 Richard Hughes 2009-06-25 05:31:29 EDT
That sounds sensible, but since I'm not the original author of that code, not a python legend, could you please email the PackageKit mailing list with this sugestion, and I'll make sure it gets an answer. Thanks.
Comment 2 Richard Hughes 2010-03-23 06:37:15 EDT
Is this now fixed in F12?
Comment 3 Bug Zapper 2010-04-27 11:12:09 EDT
This message is a reminder that Fedora 11 is nearing its end of life.
Approximately 30 (thirty) days from now Fedora will stop maintaining
and issuing updates for Fedora 11.  It is Fedora's policy to close all
bug reports from releases that are no longer maintained.  At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '11'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 11's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 11 is end of life.  If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora please change the 'version' of this 
bug to the applicable version.  If you are unable to change the version, 
please add a comment here and someone will do it for you.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
Comment 4 Bug Zapper 2010-06-28 09:15:03 EDT
Fedora 11 changed to end-of-life (EOL) status on 2010-06-25. Fedora 11 is 
no longer maintained, which means that it will not receive any further 
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of 
Fedora please feel free to reopen this bug against that version.

Thank you for reporting this bug and we are sorry it could not be fixed.

Note You need to log in before you can comment on or make changes to this bug.