Red Hat Bugzilla – Bug 507703
Review Request: perl-Proc-Simple - Launch and control background processes
Last modified: 2009-07-22 17:55:32 EDT
Spec URL: http://hpejakle.fedorapeople.org/packages/perl-Proc-Simple.spec SRPM URL: http://hpejakle.fedorapeople.org/packages/perl-Proc-Simple-1.24-1.fc11.src.rpm Description: The Proc::Simple package provides objects mimicing real-life processes from a user's point of view. Either external programs or perl subroutines can be launched and controlled as processes in the background.
koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1432455
1.) Please remove Require: perl(Test::More) dependency, the runtime does not depend on the testing framework. 2.) Licensing Proc/Simple.pm contains this: # This program is free software, you can redistribute it and/or # modify it under the same terms as Perl itself. Neither README nor POD documentation contains it -- please ask upstream to include the licensing conditions there. * rpmlint is quiet * name is well according to the guidelines * source matches upstream * clean and legible SPEC file, American English * runs testsuite * builds file in mock * filelists, documentation ok Needs work: - sane provides/requires - license
Jan Klepek 1) In my opinion, you maybe need to correct %file section. Because %{perl_vendorlib}/Proc would be owned by another packages like perl-Proc-*. I think these are better. %files %defattr(-,root,root,-) %doc Changes README %{perl_vendorlib}/Proc/* %{_mandir}/man3/* 2) That BuildArch is noarch seems not to be suitable for it. As I see, building package for various architectures may be better than noarch. So I advise that BuildArch should be removed.
(In reply to comment #3) > Jan Klepek > > 1) In my opinion, you maybe need to correct %file section. Because > %{perl_vendorlib}/Proc would be owned by another packages like perl-Proc-*. > > I think these are better. > > %files > %defattr(-,root,root,-) > %doc Changes README > %{perl_vendorlib}/Proc/* > %{_mandir}/man3/* This is not right -- that would leave an unowned %{perl_vendorlib}/Proc upon removal of the package, which violates the guidelines. Sharing directories is completely fine. Jan, please don't change that. > 2) That BuildArch is noarch seems not to be suitable for it. As I see, building > package for various architectures may be better than noarch. So I advise that > BuildArch should be removed. Wrong. There's nothing arch-specific in the package; it's definitely noarch.
(In reply to comment #2) > 1.) Please remove Require: perl(Test::More) dependency, the runtime does not > depend on the testing framework. > - Fixed > 2.) Licensing > > Proc/Simple.pm contains this: > # This program is free software, you can redistribute it and/or > # modify it under the same terms as Perl itself. > > Neither README nor POD documentation contains it -- please ask upstream to > include the licensing conditions there. - fixed, upstream provided new version Spec URL: http://hpejakle.fedorapeople.org/packages/perl-Proc-Simple.spec SRPM URL: http://hpejakle.fedorapeople.org/packages/perl-Proc-Simple-1.25-1.fc11.src.rpm
Ping? Does anyone continue to do package review?
Thank you Jan, seems fine now. APPROVED
New Package CVS Request ======================= Package Name: perl-Proc-Simple Short Description: Launch and control background processes Owners: hpejakle Branches: F-10 F-11 F-12 InitialCC:
We cannot create F-12 branches yet. It is way too early for that. Otherwise, CVS done.
Please rebuild this package on koji and submit push requests on bodhi for F-10/11.
perl-Proc-Simple-1.25-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/perl-Proc-Simple-1.25-1.fc10
perl-Proc-Simple-1.25-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-Proc-Simple-1.25-1.fc11
perl-Proc-Simple-1.25-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
perl-Proc-Simple-1.25-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.