Bug 507771 - Review Request: python-ctags - A python wrapper to read tags library
Summary: Review Request: python-ctags - A python wrapper to read tags library
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-06-24 06:40 UTC by kushaldas@gmail.com
Modified: 2009-06-30 21:35 UTC (History)
3 users (show)

Fixed In Version: 1.0.5-1.fc11
Clone Of:
Environment:
Last Closed: 2009-06-30 21:35:53 UTC
Type: ---
Embargoed:
panemade: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description kushaldas@gmail.com 2009-06-24 06:40:30 UTC
Spec URL: http://kushal.fedorapeople.org/packages/python-ctags.spec
SRPM URL: http://kushal.fedorapeople.org/packages/python-ctags-1.0.5-1.fc11.src.rpm
Description: A python wrapper to read tags library

Comment 1 Parag AN(पराग) 2009-06-24 08:04:17 UTC
Review:
+ package builds in mock (rawhide i586).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1433037
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
999283046710d37f93b646bf3e7cadde7b3d2619  python-ctags-1.0.5.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Package python-ctags-1.0.5-1.fc12.i586 =>
Provides: _readtags.so
Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.2) libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.4) libpthread.so.0 libpthread.so.0(GLIBC_2.0) libpython2.6.so.1.0 python(abi) = 2.6 rtld(GNU_HASH)
+ Not a GUI application

Suggestions:
1) Better use summary from PKG-INFO
2) Should use %global instead %define

APPROVED.

Comment 2 kushaldas@gmail.com 2009-06-24 08:46:42 UTC
New Package CVS Request
=======================
Package Name: python-ctags
Short Description:  A python wrapper to read tags library
Owners: kushal
Branches: F-11
InitialCC: kushal

Comment 3 Kevin Fenzi 2009-06-24 18:18:22 UTC
cvs done.

Comment 4 Fedora Update System 2009-06-29 05:40:37 UTC
python-ctags-1.0.5-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/python-ctags-1.0.5-1.fc11

Comment 5 Fedora Update System 2009-06-30 21:35:49 UTC
python-ctags-1.0.5-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.