Bug 507804 - Review Request: perl-Flickr-API - Flickr API interface
Review Request: perl-Flickr-API - Flickr API interface
Status: CLOSED ERRATA
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Lubomir Rintel
Fedora Extras Quality Assurance
:
: 515045 (view as bug list)
Depends On:
Blocks: 507805
  Show dependency treegraph
 
Reported: 2009-06-24 07:11 EDT by Michal Ingeli
Modified: 2009-10-10 16:25 EDT (History)
5 users (show)

See Also:
Fixed In Version: 1.32-2.el5
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-08-11 18:38:56 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
lkundrak: fedora‑review+
tibbs: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Michal Ingeli 2009-06-24 07:11:53 EDT
Spec URL: http://v3.sk/~xyzz/rpm/f11/perl-Flickr-API.spec
SRPM URL: http://v3.sk/~xyzz/rpm/f11/perl-Flickr-API-1.01-1.fc11.src.rpm

Description: Perl interface to the Flickr API
Comment 1 Lubomir Rintel 2009-06-26 09:03:58 EDT
1.) Licensing

README states "License: Perl Artistic License" (which sounds bad as it's not
clear if GPL is permitted as well)m while XML::Parser::LiteCopy manual reads
"This library is free software; you can redistribute it and/or modify it under
the same terms as Perl itself." (which is good). Please ask upstream for
clarification.

2.) Please remove useless requires. RPM generates the list for you and the runtime does not depend on the testing framework:

Requires:       perl(HTTP::Request)
Requires:       perl(HTTP::Response)
Requires:       perl(LWP::UserAgent)
Requires:       perl(Test::More)

(Explicitly versioned ones are ok)
Comment 2 Lubomir Rintel 2009-06-26 09:08:06 EDT
* rpmlint is quiet
* name is well according to the guidelines
* source matches upstream
* clean and legible SPEC file, American English
* runs testsuite
* builds file in mock
* filelists, documentation ok

Needs work:
- sane provides/requires
- license ok
Comment 3 Michal Ingeli 2009-08-01 03:07:56 EDT
License fixed by upstream(In reply to comment #2)
> Needs work:
> - sane provides/requires
Hopefully fixed.

> - license ok  
License fixed by upstream

Spec URL: http://v3.sk/~xyzz/rpm/f11/perl-Flickr-API.spec
SRPM URL: http://v3.sk/~xyzz/rpm/f11/perl-Flickr-API-1.02-1.fc11.src.rpm
Comment 4 Lubomir Rintel 2009-08-01 03:30:04 EDT
Seems fine now.
Thanks.

APPROVED
Comment 5 Michal Ingeli 2009-08-01 16:06:15 EDT
New Package CVS Request
=======================
Package Name: perl-Flickr-API
Short Description: Flickr API interface
Owners: ksyz
Branches: F-11 EL-5
InitialCC:
Comment 6 Juan J. Martínez 2009-08-01 16:24:06 EDT
*** Bug 515045 has been marked as a duplicate of this bug. ***
Comment 7 Juan J. Martínez 2009-08-01 16:25:33 EDT
I asked upstream to change the license, but I didn't realize the work being done here, so I marked Bug 515045 as duplicated of this.
Comment 8 Jason Tibbitts 2009-08-01 16:29:46 EDT
CVS done.
Comment 9 Fedora Update System 2009-08-10 15:02:27 EDT
perl-Flickr-API-1.02-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/perl-Flickr-API-1.02-1.fc11
Comment 10 Fedora Update System 2009-08-11 18:38:51 EDT
perl-Flickr-API-1.02-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 11 Fedora Update System 2009-08-25 08:14:51 EDT
perl-Flickr-API-1.02-1.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/perl-Flickr-API-1.02-1.el5
Comment 12 Fedora Update System 2009-09-17 14:01:07 EDT
perl-Flickr-API-1.02-1.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 13 Fedora Update System 2009-09-23 02:49:08 EDT
perl-Flickr-Upload-1.32-2.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/perl-Flickr-Upload-1.32-2.el5
Comment 14 Fedora Update System 2009-10-10 16:25:37 EDT
perl-Flickr-Upload-1.32-2.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.