Red Hat Bugzilla – Bug 507944
Slight chance for uninitialized self.kdumpEnabled variable
Last modified: 2015-01-07 19:16:49 EST
Description of problem:
kexec-tools-2.0.0-16.el6 has a slight exposure for an uninitialized variable.
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. Install a system where crashkernel is on the cmdline but the kdump service itself is chkconfig'd off
2. Boot up the system into firstboot
Traceback (most recent call last):
File "/usr/lib64/python2.6/site-packages/firstboot/interface.py", line 274,
File "/usr/share/firstboot/modules/firstboot_kdump.py", line 158, in
self.initialState = self.kdumpEnabled
AttributeError: moduleClass instance has no attribute 'kdumpEnabled'
Love, luck and lollipops!
While fairly contrived, I could see the case where this might happen somehow. And given that the fix is simply initializing the self.kdumpEnabled variable in the createScreen function, makes more sense to just initialize instead of risk customers hitting the error.
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux major release. Product Management has requested further
review of this request by Red Hat Engineering, for potential inclusion in a Red
Hat Enterprise Linux Major release. This request is not yet committed for
fixed in -17.el6. I actually found several variables that were previously global but needed to be made part of the class instance here, so I've fixed them all. Thanks!
Fixed in 'kexec-tools-2.0.0-33.el6'. 'kexec-tools-2.0.0-36.el6' included in compose 'RHEL6.0-20091029.0'.
Moving to ON_QA.
Fix confirmed with 2.0.0-37.el6 which is included in the 20091103.0 tree.
kexec-tools-2.0.0-48.el6 included in RHEL6.0-20100116.0.