Spec URL: http://www.topdog-software.com/oss/SRPMS/fedora/php-pear-HTML-Javascript/php-pear-HTML-Javascript.spec SRPM URL: http://www.topdog-software.com/oss/SRPMS/fedora/php-pear-HTML-Javascript/php-pear-HTML-Javascript-1.1.1-1.fc11.src.rpm Description: The PEAR::HTML_Javascript package provides methods for creating simple JS scripts * Package built as per package maintainers wishlist - http://fedoraproject.org/wiki/Package_maintainers_wishlist#P * rpmlint silent on spec and rpms * Builds on Koji - http://koji.fedoraproject.org/koji/taskinfo?taskID=1435562
Some notes: * Naming - I think this srpm must be named as just php-pear-HTML_Javascript. * Directory ownership issue / %files entry - (At least) on rawhide %{pear_phpdir}/ is expanded as /usr/share/pear so ------------------------------------------------------------- %files %{pear_phpdir}/* ------------------------------------------------------------- contains all files/directories/etc under /usr/share/pear. On the other hand %{pear_xmldir} as /usr/share/pear/.pkgxml and %{pear_testdir} as /usr/share/pear/test, so current %files entry causes duplicate file list: ------------------------------------------------------------- warning: File listed twice: /usr/share/pear/test/HTML_Javascript warning: File listed twice: /usr/share/pear/test/HTML_Javascript/tests warning: File listed twice: /usr/share/pear/test/HTML_Javascript/tests/js.php warning: File listed twice: /usr/share/pear/test/HTML_Javascript/tests/output.php ------------------------------------------------------------- - Also the following directories (themselves) are already owned by php-common so this rpm should not own them. ------------------------------------------------------------- /usr/share/pear/doc /usr/share/pear/test -------------------------------------------------------------
* Package has been renamed * Directory ownership has been fixed. Updated Spec and SRPMS SPEC: http://www.topdog-software.com/oss/SRPMS/fedora/php-pear-HTML-Javascript/php-pear-HTML_Javascript.spec SRPM: http://www.topdog-software.com/oss/SRPMS/fedora/php-pear-HTML-Javascript/php-pear-HTML_Javascript-1.1.1-2.fc11.src.rpm
For -2: * Directory ownership issue - Well, I don't know well which package should own the directory %{pear_phpdir}/HTML/. * -1 binary rpm owned this directory * now -2 binary rpm does not own this directory * On dist-f12 tree only "php-pear-HTML-Common" binary rpm owns this directory, however currently this rpm (php-pear-HTML_Javascript) does not depend on php-pear-HTML-Common So two solutions. Either: - make php-pear-HTML_Javascript depend on (i.e Requires) php-pear(HTML_Common) - or make php-pear-HTML_Javascript also own %{pear_phpdir}/HTML/
I have gone with adding a dependency on php-pear-HTML-Common, Updated Spec and SRPM SPECS: http://www.topdog-software.com/oss/SRPMS/fedora/php-pear-HTML-Javascript/php-pear-HTML_Javascript.spec SRPMS: http://www.topdog-software.com/oss/SRPMS/fedora/php-pear-HTML-Javascript/php-pear-HTML_Javascript-1.1.1-3.fc11.src.rpm
Okay. -------------------------------------------------------------------- This package (php-pear-HTML_Javascript) is APPROVED by mtasaka --------------------------------------------------------------------
Thanks for the review Mamoru, New Package CVS Request ======================= Package Name: php-pear-HTML_Javascript Short Description: Class for creating simple JS scripts Owners: topdog Branches: F-10 F-11 InitialCC: mtasaka
cvs done.
php-pear-HTML_Javascript-1.1.1-3.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/php-pear-HTML_Javascript-1.1.1-3.fc11
php-pear-HTML_Javascript-1.1.1-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/php-pear-HTML_Javascript-1.1.1-3.fc10
Now closing.
Package Change Request ====================== Package Name: php-pear-HTML_Javascript New Branches: EL-5 Owners: topdog
php-pear-HTML_Javascript-1.1.1-3.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
php-pear-HTML_Javascript-1.1.1-3.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.