Bug 508262 - Fence agents ends with traceback when option is missing
Summary: Fence agents ends with traceback when option is missing
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: cman
Version: 5.3
Hardware: All
OS: Linux
low
medium
Target Milestone: rc
: ---
Assignee: Marek Grac
QA Contact: Cluster QE
URL:
Whiteboard:
Depends On:
Blocks: 508268
TreeView+ depends on / blocked
 
Reported: 2009-06-26 11:21 UTC by Marek Grac
Modified: 2016-04-26 13:39 UTC (History)
5 users (show)

Fixed In Version: cman-2.0.115-4.el5
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 508268 (view as bug list)
Environment:
Last Closed: 2010-03-30 08:41:17 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Proposed patch (3.18 KB, patch)
2009-08-31 15:15 UTC, Marek Grac
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2010:0266 0 normal SHIPPED_LIVE cman bug fix and enhancement update 2010-03-29 12:54:44 UTC

Description Marek Grac 2009-06-26 11:21:28 UTC
If WTI device expects login and login name is not entered then it fails with traceback. Correct error message is expected.

Login name is required for WTI, so it has to be checked after login is encountered.

Comment 1 Marek Grac 2009-06-26 11:29:01 UTC
Same problem can occur with password (also optional on wti)

Comment 5 Marek Grac 2009-08-31 15:15:22 UTC
Created attachment 359277 [details]
Proposed patch

Similar problem exists also for APC

Comment 10 Jaroslav Kortus 2010-03-11 17:19:22 UTC
[root@z2 ~]# echo -e "ipaddr=1.1.1.1\nport=44\nipport=54444\n" | fence_apc
Failed: You have to set login name

[root@z2 ~]# echo -e "ipaddr=1.1.1.1\nport=44\nipport=54444\nlogin=x\n" | fence_apc
Failed: You have to enter password or password script

fence_apc clearly still requires both login and password to start any operation. Is this as intended?

Comment 12 Perry Myers 2010-03-12 17:42:03 UTC
(In reply to comment #10)
> [root@z2 ~]# echo -e "ipaddr=1.1.1.1\nport=44\nipport=54444\n" | fence_apc
> Failed: You have to set login name
> 
> [root@z2 ~]# echo -e "ipaddr=1.1.1.1\nport=44\nipport=54444\nlogin=x\n" |
> fence_apc
> Failed: You have to enter password or password script
> 
> fence_apc clearly still requires both login and password to start any
> operation. Is this as intended?    

Yes.  username/password is required.  This bug wasn't about username/password not being required.  It was that when username/password wasn't given to fence_wti, the fence agent would fail in a non graceful manner.

As you can see, the apc fence agent is failing in a graceful manner and prompting the user for the username/password as appropriate

Did you check the WTI agent specifically to make sure that the traceback is gone?

Comment 13 Lon Hohberger 2010-03-12 17:56:11 UTC
APC fencing devices always require username and password.

WTI fencing devices usually require both.  Older devices such as the IPS may get by with only the password.

Comment 14 Lon Hohberger 2010-03-12 17:56:55 UTC
that is: the fence_wti agent should not _require_ a username, only a password.

APC should require both.

Comment 15 Lon Hohberger 2010-03-12 17:57:39 UTC
> fence_apc clearly still requires both login and password to start any
> operation. Is this as intended?    

Yeah, that's correct behavior for fence_apc.

Comment 16 Jaroslav Kortus 2010-03-12 19:38:18 UTC
the wti agent worked as expected, so if the apc case is also as it should be, I'm marking this as verified. Thanks for comments.

Comment 18 errata-xmlrpc 2010-03-30 08:41:17 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2010-0266.html


Note You need to log in before you can comment on or make changes to this bug.