This service will be undergoing maintenance at 00:00 UTC, 2016-08-01. It is expected to last about 1 hours
Bug 508316 - Review Request: emacs-jabber - Jabber plugin for emacs
Review Request: emacs-jabber - Jabber plugin for emacs
Status: CLOSED NOTABUG
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
low Severity medium
: ---
: ---
Assigned To: Nobody's working on this, feel free to take it
Fedora Extras Quality Assurance
:
: 522046 (view as bug list)
Depends On:
Blocks: FE-DEADREVIEW
  Show dependency treegraph
 
Reported: 2009-06-26 10:36 EDT by Rakesh Pandit
Modified: 2010-11-08 22:09 EST (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2010-11-08 22:09:36 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:


Attachments (Terms of Use)
Fixes free variable reference warnings (3.23 KB, patch)
2009-12-08 09:37 EST, Shakthi Kannan
no flags Details | Diff

  None (edit)
Description Rakesh Pandit 2009-06-26 10:36:26 EDT
SPEC: http://rakesh.fedorapeople.org/spec/emacs-jabber.spec 
SRPM: http://rakesh.fedorapeople.org/srpm/emacs-jabber-0.7.93-1.fc11.src.rpm

Description:
Emacs plugin for jabber protocol.
Comment 1 Rakesh Pandit 2009-07-10 12:26:56 EDT
(setq tls-program '("openssl s_client -connect %h:%p -no_ssl2 -no_ticket"))
(setq jabber-account-list '(
                            ("rakesh.pandit@gmail.com"
                             (:password . nil)
                              (:network-server . "talk.google.com")
                              (:connection-type . ssl))
                            ))

Just of testing purpose this is configuration I am using on my F11 box for gmail
Comment 2 Jason Tibbitts 2009-09-09 14:02:38 EDT
*** Bug 522046 has been marked as a duplicate of this bug. ***
Comment 3 Arun S A G 2009-09-10 03:36:07 EDT
rpmlint on created rpm shows following warnings and errors:

emacs-jabber.noarch: W: non-conffile-in-etc /etc/gconf/schemas/emacs-jabber.schemas
emacs-jabber.noarch: E: wrong-script-end-of-line-encoding /usr/libexec/xmppuri.sh
emacs-jabber.noarch: E: script-without-shebang /usr/share/emacs/site-lisp/site-start.d/jabber-init.el

#1: wrong-script-end-of-line-encoding /usr/libexec/xmppuri.sh
Error can be removed by running 'sed -i 's/\r//' on xmppuri.sh

#2: I don't know what you are doing with gconf schema is right or wrong
please have a look at http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GConf

#3: why we need jabber-init.el ?
copying jabber-autoloads.el inside site-start.d/ works  for me. (correct me if i am wrong)
Comment 4 Arun S A G 2009-09-12 10:45:16 EDT
New version of jabber.el is available (version 0.8) http://sourceforge.net/projects/emacs-jabber/files/ .

Can i start packaging  it?
Comment 5 Rakesh Pandit 2009-09-14 06:10:25 EDT
http://rakesh.fedorapeople.org/spec/emacs-jabber.spec
http://rakesh.fedorapeople.org/srpm/emacs-jabber-0.8.0-1.fc12.src.rpm

Addresses all issues.

#1 done

#2 done (removed by adding configure option)

#3 jabber-init is the file which adds site-lisp/jabber to load-path, and it is required. Rpmlint output on it can be ignored.

Thanks,
Comment 6 Arun S A G 2009-09-18 22:23:20 EDT
Hi,
 
Package works fine except rpmlint on emacs-jabber-el-0.8.0-1.fc11.noarch.rpm emits
"emacs-jabber.noarch: E: script-without-shebang /usr/share/emacs/site-lisp/site-start.d/jabber-init.el"

To fix the Error please refer https://fedoraproject.org/wiki/Common_Rpmlint_issues#script-without-shebang
Comment 8 Shakthi Kannan 2009-12-08 09:37:39 EST
Created attachment 376915 [details]
Fixes free variable reference warnings

#01 Shouldn't the pkgname start with capital 'E'macs ? I see it is being used in the Name and in turn in Source0 as well, where the source tarball name starts with emacs-jabber-.

https://fedoraproject.org/wiki/Packaging:Emacs#Template_for_a_add-on_package_for_GNU_Emacs_only

#02 Attached is a patch to fix the 'free reference to variables' warnings.

#03 We can use (declare-function foo) to stop the 'function X might not be defined at runtime' warning, but, declare-function is only available from Emacs 23. Otherwise, we can ignore the warning if you want to use with from Emacs 22.

#04 Retain time stamp with 'cp -p', instead of using 'mv' in %install

cp -p $RPM_BUILD_ROOT%{emacs_lispdir}/*.el* \
 $RPM_BUILD_ROOT%{emacs_lispdir}/%{pkg}/

#05 Cosmetic change, use %{buildroot} instead of $RPM_BUILD_ROOT?

I have tested this package and it works.
Comment 9 Arun S A G 2010-08-12 22:12:06 EDT
Please update this package. I will do the review this weekend.
Comment 10 Jason Tibbitts 2010-11-02 19:14:09 EDT
Anything happening here?  It looks as if there was a willing reviewer.

Note You need to log in before you can comment on or make changes to this bug.