Spec URL: http://than.fedorapeople.org/rawhide/kdepim-runtime.spec SRPM URL http://than.fedorapeople.org/rawhide/http://than.fedorapeople.org/rawhide/kdepim-runtime-4.2.95-1.fc11.src.rpm Description: KDE PIM Runtime Environment
Some quick comments: 0. drop the epoch, this is a new pkg 1. missing desktop-file-install/desktop-file-validate 2. missing icon/mime scriptlets 3. do we really want/need Provides: kdepim4 = %{version}-%{release} here? 4. Source URL is wrong (s/stable/unstable), but that's minor
>0. drop the epoch, this is a new pkg it's fixed >1. missing desktop-file-install/desktop-file-validate is it really required to use desktop-file-install/desktop-file-validate? >2. missing icon/mime scriptlets add missing update-mime-database, it's fixed >3. do we really want/need >Provides: kdepim4 = %{version}-%{release} >here? it's not needed, drop it >4. Source URL is wrong (s/stable/unstable), but that's minor it's fixed new specs and srpm uploaded
Yes, 1, is needed, for items under /usr/share/applications/, but we can deal with that post-review, I won't consider it a blocker for now.
Ah, I see you added it, good. The rest looks good now, can't test buildability/runtime yet, but we'll deal with that when the rest of kde-4.3-rc2 is built. APPROVED.
New Package CVS Request ======================= Package Name: kdepim-runtime Short Description: KDE PIM Runtime Environment Owners: than Branches: F-10 F-11 InitialCC:
CVS done.