Bug 508518 - Review Request: meiga - Easy tool for file sharing and content publishing
Summary: Review Request: meiga - Easy tool for file sharing and content publishing
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Thomas Spura
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2009-06-28 09:12 UTC by Rajeesh
Modified: 2009-11-19 15:06 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2009-11-19 15:06:14 UTC
Type: ---
tomspur: fedora-review+
j: fedora-cvs+

Attachments (Terms of Use)

Description Rajeesh 2009-06-28 09:12:14 UTC
Spec URL: http://rajeeshknambiar.fedorapeople.org/meiga.spec
SRPM URL: http://rajeeshknambiar.fedorapeople.org/meiga-0.2.0-1.fc11.src.rpm
Meiga is a lightweight, easy to use, network friendly and also
application friendly content server for desktop.
Client side does not need to install any software, as the
shared files can be accessed using web browser. The ultimate
goal is to serve as a common publishing pont for desktop
applications, such as file manager, picture viewers or
music players

Comment 1 Rajeesh 2009-07-03 03:28:06 UTC
While testing in Fedora, identified a bug where Meiga is not finding the internal IP, due to missing PATH settings. I talked to the upstream developer and fixed this issue in new release - 0.2.1

The updated SPEC and SRPM are:

Comment 2 Fabian Affolter 2009-07-28 10:42:24 UTC
Just some comments after a quick look at your spec file

- License should be GPLv2+.  The source headers says 'or (at your option) any later version.'
- Requires: hicolor-icon-theme is missing
- ChangeLog, MAINTAINERS and NEWS are missing in %doc
- Wouldn't it be easier for the future just to use %{_datadir}/%{name}/

instead of 

%dir %{_datadir}/%{name}
%dir %{_datadir}/%{name}/ui


Comment 3 Rajeesh 2009-07-28 12:47:48 UTC
Thanks for the suggestions!

I've updated the SPEC file and rebuilt new SRPM:


Comment 4 Thomas Spura 2009-11-07 09:57:14 UTC
There is a new version, after updating I'll review this this week, at maximum next weekend…

Comment 5 Rajeesh 2009-11-11 09:01:17 UTC

The {S,R}PMs and SPEC have been updated to the latest version, and can be found here:


Koji scratch build : http://koji.fedoraproject.org/koji/taskinfo?taskID=1800417

Comment 6 Thomas Spura 2009-11-14 18:17:41 UTC

- Sources match upstream
- $ rpmlint meiga.spec  meiga-0.3.1-1.fc12.src.rpm x86_64/meiga-0.3.1-1.fc12.x86_64.rpm x86_64/meiga-debuginfo-0.3.1-1.fc12.x86_64.rpm 
3 packages and 1 specfiles checked; 0 errors, 0 warnings.

- file permissions ok
- %files section ok
- properly install locales
- license GPLv2+ ok
- package works as expected

- Gnome users are currently forced to install kde-filesystem. If you split the .desktop files for kde into a subpackage, this would help a lot. But this is no requirement.
- When installing there is a  gtk-update-icon-cache: No theme index file.
  Don't not how to eliminate this, but not a blocker atm.
- When building, there is a intltoolize: 'po/Makefile.in.in' exists: use '--force' to overwrite
  So please add --force to intltoolize

This are only minor issues, so this package is:



Comment 7 Rajeesh 2009-11-15 07:17:30 UTC
Hi Thomas,

Thanks for the review and approval!

Your comments are addressed in the new build, except the gtk-update-icon-cache issue. I guess this is due to running gtk-update-icon-cache on /usr/share/pixmaps. I don't know how to fix it, or can it be simply omitted?


I am requesting for the CVS access.
New Package CVS Request
Package Name: meiga
Short Description: Easy to use tool to share selected local directories via web
Owners: rajeeshknambiar
Branches: F-11 F-12 EL-5

Comment 8 Jason Tibbitts 2009-11-16 17:42:27 UTC
CVS done.

Comment 9 Rajeesh 2009-11-19 15:06:14 UTC
Built and submitted update for Fedora 11. https://admin.fedoraproject.org/updates/F11/FEDORA-2009-11709

Note You need to log in before you can comment on or make changes to this bug.