Bug 508593 - dropped rootprivs patch
Summary: dropped rootprivs patch
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: kdebase-workspace
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Kevin Kofler
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-06-28 23:35 UTC by Rex Dieter
Modified: 2009-06-30 15:56 UTC (History)
11 users (show)

Fixed In Version: 4.2.95-2
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-06-30 15:56:39 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Rex Dieter 2009-06-28 23:35:04 UTC
Looks like as of kdebase-workspace-4.2.85 the rootprivs patch, providing admin/root mode to systemsettings, was dropped.

Comment 1 Kevin Kofler 2009-06-29 15:37:15 UTC
I'm investigating.

Comment 2 Kevin Kofler 2009-06-29 15:57:03 UTC
System Settings has been completely reorganized in 4.3, I need to locate the places to change and then manually apply the changes. I'll do so ASAP.

Comment 3 Rex Dieter 2009-06-29 16:00:56 UTC
systemsettings/app/main.cpp  is where much of the existing patch still applies, if that helps.

Comment 4 Kevin Kofler 2009-06-29 16:53:18 UTC
That file is mostly empty in 4.2.95 (there's just a small main function) and doesn't contain any of the code being patched.

Comment 5 Kevin Kofler 2009-06-29 17:19:45 UTC
OK, I found the code in systemsettings/core/ModuleView.cpp and ported the patch. For reference, the original kdebase-workspace-4.1.2-rootprivs.patch had 5 hunks:
1. adds #include <QProcess>
2. adds #include <KStandardDirs>
3. removes duplicate connection of the selectionChanged slot to prevent kdesu from getting started twice
4. checks X-KDE-RootOnly property and sets bool needsRootPrivs
5. does the actual work based on needsRootPrivs
What I did:
1. dropped, as ModuleView.cpp already includes <QProcess>
2. ported (trivial)
3. dropped as this bug is fixed upstream. The connection is now done in IconMode::initWidget() in systemsettings/icons/IconMode.cpp and it's a single:
        connect( tv, SIGNAL( activated( const QModelIndex& ) ),
                 this, SLOT( changeModule(const QModelIndex& ) ) );
The bogus connections to the clicked or doubleClicked signals are gone.
4. and 5. ported, combined (did away with the unneeded boolean and just checked the property directly)


Note You need to log in before you can comment on or make changes to this bug.