Bug 508984 - Remove rhpl usage
Summary: Remove rhpl usage
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: system-config-users
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Nils Philippsen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: rhplectomy
TreeView+ depends on / blocked
 
Reported: 2009-06-30 18:20 UTC by Jeremy Katz
Modified: 2009-09-03 12:29 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-09-03 12:29:21 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)
rhpl.translate -> gettext (4.81 KB, patch)
2009-06-30 18:21 UTC, Jeremy Katz 		no flags Details | Diff
Switch to unicode() instead of rhpl.iconv (1.22 KB, patch)
2009-06-30 18:22 UTC, Jeremy Katz 		no flags Details | Diff
rhpl.executil -> subprocess (1.17 KB, patch)
2009-06-30 18:23 UTC, Jeremy Katz 		no flags Details | Diff
View All

Description Jeremy Katz 2009-06-30 18:20:28 UTC 
system-config-users uses rhpl for a few things.  I've gone ahead and worked up patches to remove the dependency for all three cases
Comment 1 Jeremy Katz 2009-06-30 18:21:31 UTC 
Created attachment 349994 [details]
rhpl.translate -> gettext
Comment 2 Jeremy Katz 2009-06-30 18:22:05 UTC 
Created attachment 349995 [details]
Switch to unicode() instead of rhpl.iconv

This should be good -- rhpl.iconv was much more needed in the pre-python2 days when bfox wrote the code :)
Comment 3 Jeremy Katz 2009-06-30 18:23:06 UTC 
Created attachment 349996 [details]
rhpl.executil -> subprocess

This is a direct conversion.  I think it'd be better, though, to switch to using os.unlink and shutil.rmtree instead of this method.
Comment 4 Nils Philippsen 2009-09-03 12:29:21 UTC 
fixed in version 1.2.88
Note You need to log in before you can comment on or make changes to this bug.