Red Hat Bugzilla – Bug 50919
two Python modules in redhat-config-network import each other
Last modified: 2015-03-04 20:09:25 EST
Description of Problem:
NCProfileList.py and ProfileList.py import each other:
NCProfileList.py line 27:
from ProfileList import *
and ProfileList.py line 1518:
from NCProfileList import *
I'm not sure that this is a problem per se, but some things seem to be
crossing over unintentionally, like in editdomain.py on line 88:
profilelist = ProfileList.getProfileList()
getProfileList doesn't exist in ProfileList.py, but rather in NCProfileList.py.
Steps to Reproduce:
1. examine code.
I'm not sure, but shouldn't the imports be only one-way? And if a function
is called, shouldn't the call indicate the correct module that the function
OK, fixed in CVS.
Concerning the cross imports: We need them to some degree as otherwise our
namespacing would get horribly messy...
We've spent quite some time to clean this up as much as possible, but that one
obviously slipped through our net of checks.
Read ya, Phil