Bug 509315 - Review Request: perl-CGI-Application-Plugin-Forward - Pass control from one run mode to another in CGI::Application
Summary: Review Request: perl-CGI-Application-Plugin-Forward - Pass control from one r...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-07-02 07:05 UTC by Emmanuel Seyman
Modified: 2009-07-16 06:55 UTC (History)
3 users (show)

Fixed In Version: 1.06-1.fc11
Clone Of:
Environment:
Last Closed: 2009-07-16 06:55:50 UTC
Type: ---
Embargoed:
panemade: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Emmanuel Seyman 2009-07-02 07:05:37 UTC
Spec URL: http://people.parinux.org/~seyman/fedora/perl-CGI-Application-Plugin-Forward/perl-CGI-Application-Plugin-Forward.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-CGI-Application-Plugin-Forward/perl-CGI-Application-Plugin-Forward-1.06-1.fc11.src.rpm
Description:
This module gives CGI::Application a forward method that passes control
to another run mode and returns its output. This is equivalent to calling
$self->$other_runmode, except that CGI::Application's internal value of
the current run mode is updated.

Comment 1 Parag AN(पराग) 2009-07-02 09:30:05 UTC
Review:
+ package builds in mock (rawhide i586).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1449056
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
2853d3a87aa5ac2e2770404b4c558dfc4e8ea782  CGI-Application-Plugin-Forward-1.06.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=8, Tests=50,  1 wallclock secs ( 0.04 usr  0.01 sys +  0.39 cusr  0.04 csys =  0.48 CPU)
+ Package  perl-CGI-Application-Plugin-Forward-1.06-1.fc12.noarch =>
Provides: perl(CGI::Application::Plugin::Forward) = 1.06
Requires: perl(CGI::Application) perl(Carp) perl(strict) perl(vars) perl(warnings)
+ Not a GUI application

APPROVED.

Comment 2 Emmanuel Seyman 2009-07-03 09:21:00 UTC
Thanks! Requesting CVS.

New Package CVS Request
=======================
Package Name: perl-CGI-Application-Plugin-Forward
Short Description: Pass control from one run mode to another in CGI::Application
Owners: eseyman
Branches: F-11 F-10
InitialCC: perl-sig

Comment 3 Kevin Fenzi 2009-07-06 04:16:10 UTC
cvs done.

Comment 4 Fedora Update System 2009-07-06 09:53:07 UTC
perl-CGI-Application-Plugin-Forward-1.06-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/perl-CGI-Application-Plugin-Forward-1.06-1.fc11

Comment 5 Fedora Update System 2009-07-11 17:20:12 UTC
perl-CGI-Application-Plugin-Forward-1.06-1.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update perl-CGI-Application-Plugin-Forward'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-7482

Comment 6 Fedora Update System 2009-07-16 06:55:45 UTC
perl-CGI-Application-Plugin-Forward-1.06-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.