Spec URL: http://people.parinux.org/~seyman/fedora/perl-CGI-Application-Plugin-TT/perl-CGI-Application-Plugin-TT.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-CGI-Application-Plugin-TT/perl-CGI-Application-Plugin-TT-1.04-1.fc11.src.rpm Description: CGI::Application::Plugin::TT adds support for the popular Template Toolkit engine to your CGI::Application modules by providing several helper methods that allow you to process template files from within your runmodes.
Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1452265 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 8457506a05277b125cb3f8367150ff8f3c97a4f5 CGI-Application-Plugin-TT-1.04.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=11, Tests=61, 3 wallclock secs ( 0.09 usr 0.03 sys + 2.56 cusr 0.16 csys = 2.84 CPU) + Package perl-CGI-Application-Plugin-TT-1.04-1.fc12.noarch => Provides: perl(CGI::Application::Plugin::TT) = 1.04 Requires: perl(CGI::Application) >= 4.0 perl(Carp) perl(Exporter) perl(File::Spec) perl(Scalar::Util) perl(Template) >= 2.0 perl(strict) perl(vars) + Not a GUI application APPROVED.
(In reply to comment #1) > > APPROVED. Thanks for the review! Requesting CVS. New Package CVS Request ======================= Package Name: perl-CGI-Application-Plugin-TT Short Description: Add Template Toolkit support to CGI::Application Owners: eseyman Branches: F-11 F-10 InitialCC: perl-sig
cvs done.
perl-CGI-Application-Plugin-TT-1.04-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-CGI-Application-Plugin-TT-1.04-1.fc11
perl-CGI-Application-Plugin-TT-1.04-1.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-CGI-Application-Plugin-TT'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-7519
perl-CGI-Application-Plugin-TT-1.04-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.