Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 510099

Summary: printk in rtc-dev.c missing a loglevel prefix
Product: Red Hat Enterprise MRG Reporter: Guy Streeter <streeter>
Component: realtime-kernelAssignee: Red Hat Real Time Maintenance <rt-maint>
Status: CLOSED ERRATA QA Contact: David Sommerseth <davids>
Severity: medium Docs Contact:
Priority: low    
Version: 1.2CC: bhu, lgoncalv, nobody, ovasik
Target Milestone: 1.1.5   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-07-14 19:12:06 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Guy Streeter 2009-07-07 17:01:01 UTC
The patch to add /dev/rtc has a printk without a log level prefix on it. This will result at leat in formatting problems, and possibly cause the message to not appear when it should.

The line in drivers/rtc/rtc-dev.c in function rtc_dev_add_device()

printk("rtc_dev_add_device: misc_register() failed for compat_rtc\n");

should be

printk(KERN_WARNING "rtc_dev_add_device: misc_register() failed for compat_rtc\n");

or possibly KERN_ERR

Comment 1 Luis Claudio R. Goncalves 2009-07-07 17:57:45 UTC
Patch added to -126

Comment 3 David Sommerseth 2009-07-09 17:44:01 UTC
Verified by code review.  Found suggested fix in comment #0 as mrg-rt.git commit 0a77c39be04294b3c02dcff8dba79e18aca77616 implemented in kernel-rt-2.6.24.7-126  (CVS: bz510099-fix-printk-in-rtc_dev_add_device.patch)

Comment 5 errata-xmlrpc 2009-07-14 19:12:06 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2009-1157.html