Bug 510099 - printk in rtc-dev.c missing a loglevel prefix
Summary: printk in rtc-dev.c missing a loglevel prefix
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise MRG
Classification: Red Hat
Component: realtime-kernel
Version: 1.2
Hardware: All
OS: Linux
low
medium
Target Milestone: 1.1.5
: ---
Assignee: Red Hat Real Time Maintenance
QA Contact: David Sommerseth
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-07-07 17:01 UTC by Guy Streeter
Modified: 2016-05-22 23:35 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-07-14 19:12:06 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2009:1157 0 normal SHIPPED_LIVE Important: kernel-rt security and bug fix update 2009-07-14 19:11:05 UTC

Description Guy Streeter 2009-07-07 17:01:01 UTC 
The patch to add /dev/rtc has a printk without a log level prefix on it. This will result at leat in formatting problems, and possibly cause the message to not appear when it should.

The line in drivers/rtc/rtc-dev.c in function rtc_dev_add_device()

printk("rtc_dev_add_device: misc_register() failed for compat_rtc\n");

should be

printk(KERN_WARNING "rtc_dev_add_device: misc_register() failed for compat_rtc\n");

or possibly KERN_ERR
Comment 1 Luis Claudio R. Goncalves 2009-07-07 17:57:45 UTC 
Patch added to -126
Comment 3 David Sommerseth 2009-07-09 17:44:01 UTC 
Verified by code review.  Found suggested fix in comment #0 as mrg-rt.git commit 0a77c39be04294b3c02dcff8dba79e18aca77616 implemented in kernel-rt-2.6.24.7-126  (CVS: bz510099-fix-printk-in-rtc_dev_add_device.patch)
Comment 5 errata-xmlrpc 2009-07-14 19:12:06 UTC 
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2009-1157.html
Note You need to log in before you can comment on or make changes to this bug.