Spec URL: http://mef.fedorapeople.org/packages/eclipse-slice2java/eclipse-slice2java.spec SRPM URL: http://mef.fedorapeople.org/packages/eclipse-slice2java/eclipse-slice2java-3.3.1-1.fc11.src.rpm Description: The slice2java plugin manages the translation of Slice to Java. The plugin computes dependencies between Slice files and automatically recompiles Slice files when necessary. The plugin also manages the generated code to eliminate obsolete files.
I should really set up some sort of notification for eclipse packages proposed for review :) I'll take this one.
Sorry, this somehow slipped off of my to-do list. A few comments: - is this commented-out line okay? BuildRequires: ice-java >= 3.3.1 - you probably don't need to build gcj bits since the rest of the Eclipse SDK doesn't have them - I believe Alex fixed the pdebuild wrapper script to avoid the need for -a "-DjavacSource=1.5 -DjavacTarget=1.5" but it's not harming anything so feel free to leave it - there appears to be a typo in the readme file. I think "Activating the Plugin for a Project" should be on a new line. Otherwise: OK naming good OK file locations fine OK licensing fine OK md5sum matches upstream OK rpmlint fine $ rpmlint eclipse-slice2java-3.3.1-1.fc11.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint ../RPMS/x86_64/eclipse-slice2java-3.3.1-1.fc12.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. PLEASEFIX please use either %{buildroot} OR $RPM_BUILD_ROOT but not both
Thanks for the review! Here are updated files: http://mef.fedorapeople.org/packages/eclipse-slice2java/eclipse-slice2java.spec http://mef.fedorapeople.org/packages/eclipse-slice2java/eclipse-slice2java-3.3.1.20090330-2.fc12.src.rpm
Thanks for the changes. Everything looks fine now except for the date in the version string. Upstream is sort of confusing in this regard, but it looks like 3.3.1 is the version. Unless you think I'm mis-interpreting upstream's version number, I think you can avoid including it in the Version/Release entirely. Also, there's a newer snapshot available (20091005) if you want to get that one in.
Thanks for pointing out the newer version -- hadn't noticed that. (I wonder what they changed ...) I can remove the date, but it does kind of seem like the date is part of the version -- I mean, these are all 3.3.1 (because they work with Ice 3.3.1) but there are new versions within that. But this isn't a big deal and I can remove it again without difficulty.
Also, looking at the changelog, it contains things like "Changes since version 3.3.1.20090330" which sort of implies that the date is part of the version number.
Okay, then the date is part of the upstream version. At least it appears to be monotonically increasing :)
I've updated to the newer version from upstream and added the CHANGELOG to the %doc -- no other changes. http://mef.fedorapeople.org/packages/eclipse-slice2java/eclipse-slice2java.spec http://mef.fedorapeople.org/packages/eclipse-slice2java/eclipse-slice2java-3.3.1.20091005-1.fc12.src.rpm
(If you were *very* fast, you'll need to download again -- I just noticed that the CHANGELOG was in the tarball so I don't need to download it again from the website.)
Everything looks good. Approved.
New Package CVS Request ======================= Package Name: eclipse-slice2java Short Description: A plugin that integrates Eclipse with Ice object middleware Owners: mef Branches: F-11 F-12 InitialCC:
CVS done.
eclipse-slice2java-3.3.1.20091005-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/eclipse-slice2java-3.3.1.20091005-1.fc11
eclipse-slice2java-3.3.1.20091005-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/eclipse-slice2java-3.3.1.20091005-1.fc12
eclipse-slice2java-3.3.1.20091005-1.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update eclipse-slice2java'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2009-12633
eclipse-slice2java-3.3.1.20091005-1.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update eclipse-slice2java'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-12732
eclipse-slice2java-3.3.1.20091005-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
eclipse-slice2java-3.3.1.20091005-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.