cherry-picked into the RHEL53 branch

commit 2bac6a6e1a24cd56f08bb89299296bf2a9a6ea58
Author: Christine Caulfield <ccaulfie>
Date:   Wed Dec 3 10:46:20 2008 +0000

    cman: Fix inconsistent state if a node leaves/joins quickly

I am still able to get the cluster in an inconsistent state after running "service cman restart" on one node.

[nstraz@z ~]$ for i in z{1,2,3,4}; do echo "$i:"; qarsh -l root $i cman_tool nodes; done
z1:
Node  Sts   Inc   Joined               Name
   1   M   1228   2009-07-24 08:58:41  z1
   2   M   1240   2009-07-24 08:59:11  z2
   3   M   1232   2009-07-24 08:58:41  z3
   4   M   1232   2009-07-24 08:58:41  z4
z2:
Node  Sts   Inc   Joined               Name
   1   M   1240   2009-07-24 08:59:12  z1
   2   M   1236   2009-07-24 08:59:12  z2
   3   M   1240   2009-07-24 08:59:12  z3
   4   M   1240   2009-07-24 08:59:12  z4
z3:
Node  Sts   Inc   Joined               Name
   1   M   1232   2009-07-24 08:58:41  z1
   2   M   1240   2009-07-24 08:59:11  z2
   3   M   1216   2009-07-24 08:32:16  z3
   4   M   1224   2009-07-24 08:32:17  z4
z4:
Node  Sts   Inc   Joined               Name
   1   X   1224                        z1
   2   X   1224                        z2
   3   M   1224   2009-07-24 08:32:18  z3
   4   M   1220   2009-07-24 08:32:17  z4

Given that bz#472786 has been verified as fixed, and it's the same bug, are we sure that the Z-stream package has that patch included ?

Yes, I talked with nate and he is using cman-2.0.98-1.el5_3.7 which I verified contains the patch:

-       if (node->state == NODESTATE_DEAD) {
+       if (node->state == NODESTATE_DEAD || node->state == NODESTATE_LEAVING) {

I reinstalled the systems and tried the test again and it passed this time around.  Last time I was working with 3, 4, and 5 node clusters, perhaps I didn't have all nodes updated correctly.  Calling this verified now.

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2009-1192.html