Spec URL: http://dchen.fedorapeople.org/files/rpms/ibus-table-array30.spec SRPM URL: http://dchen.fedorapeople.org/files/rpms/ibus-table-array30-1.2.0.20090714-1.fc11.src.rpm Description: The Array 30 Chinese input method for ibus-table. It covers more than 70 thousands Chinese characters, which are listed in unicode 3.1.
Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1472650 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 3d1d3e9bc8e24cfea7af24c30fca8ca940449b46 ibus-table-array30-1.2.0.20090714-Source.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + ibus-table-createdb (post) scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI application Should: 1) you should use make install as make DESTDIR=%{buildroot} INSTALL="install -p" install 2) License is not clear to me. table text file says its LGPL license. 3) Other ibus-table-* packages are not using cin2ibus.c. Any reason for using this for this package? 4) also saw other ibus-table-* packages using export IBUS_TABLE_CREATEDB="%{_bindir}/ibus-table-createdb -o" in %build.
Spec URL: http://dchen.fedorapeople.org/files/rpms/ibus-table-array30.spec SRPM URL: http://dchen.fedorapeople.org/files/rpms/ibus-table-array30-1.2.0.20090715-1.fc11.src.rpm Should: > 1) you should use make install as > make DESTDIR=%{buildroot} INSTALL="install -p" install Fixed. > 2) License is not clear to me. table text file says its LGPL license. Fixed, according to the source .cin file, it should be GPL. > 3) Other ibus-table-* packages are not using cin2ibus.c. > Any reason for using this for this package? It is my little program that convert tables in cin (for xcin/gcin) to ibus format. Since ibus-table upstream have not accepted it, I put it in my package. > 4) also saw other ibus-table-* packages using > export IBUS_TABLE_CREATEDB="%{_bindir}/ibus-table-createdb -o" in %build. I put the checking and setting inside CMakeList. According to documentation of ibus-table, Option -o should be used when packing.
Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1474634 + rpmlint is silent for SRPM and for RPM. + source files match upstream url f59f2ec8612ed962734e3d846b1ec7e7de59ff22 ibus-table-array30-1.2.0.20090715-Source.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + ibus-table-createdb(post) scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI application APPROVED.
New Package CVS Request ======================= Package Name: ibus-table-array30 Short Description: ibus-table-array30 - Array30 Chinese input method for ibus-table Owners: dchen Branches: F-10 F-11 InitialCC: i18n-team
cvs done.
*** Bug 512646 has been marked as a duplicate of this bug. ***
ibus-table-array30-1.2.0.20090729-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/ibus-table-array30-1.2.0.20090729-1.fc11
ibus-table-array30-1.2.0.20090729-1.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update ibus-table-array30'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-8367
ibus-table-array30-1.2.0.20090729-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.