Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: http://www.kernel.org/pub/software/network/distsrv/pkg/chunkd.spec SRPM URL: http://www.kernel.org/pub/software/network/distsrv/pkg/chunkd-0.3-1.fc10.src.rpm Description: Data storage daemon chunkd is a "chunk server", which is a service for storing and retrieving anonymous binary objects (BLOBs). http://linux.yyz.us/projects/chunkd.html This package is required for tabled, another package being submitted for review.
Just some quick comments on your spec file. - You are mixing '$RPM_BUILD_ROOT' and '%{buildroot}' https://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS - 'Source0' should point to the upstream location of the source tarball. https://fedoraproject.org/wiki/Packaging/SourceURL - Please add AUTHORS, ChangeLog, and all other doc files to %doc - Take a look at https://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries
Created attachment 354034 [details] Updated chunkd spec file
Created attachment 354035 [details] Updated chunkd SRPM I updated the specfile with review comments, plus a few other things I found re-reviewing packging guidelines. Successful koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1480186
Created attachment 354068 [details] Updated chunkd spec file
Created attachment 354070 [details] Updated chunkd SRPM This was updated again, to reflect applicable feedback on package cld (bug #511938): - add more %doc - %config(noreplace) - chkconfig default off Successful koji build at http://koji.fedoraproject.org/koji/taskinfo?taskID=1480771
Created attachment 354190 [details] Updated chunkd spec file
Created attachment 354192 [details] Updated chunkd SRPM Updated with feedback from sister project cld (bz#511938): - new release version scheme - kill RPM_BUILD_ROOT
Koji successful build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1482741
I'll grab this one
Because the source comes from revision control it needs to be documented how to recreate the tarfile so the source file can be verified using ms5sum etc to ensure its from upstream. Details here: https://fedoraproject.org/wiki/Packaging/SourceURL#Using_Revision_Control
A couple of things. The main one is the documentation on how to recreate the source file. Also the description could be fleshed out a little, a Data Storage Daemon for what? The description in the review request isn't too bad at least explains its for storing cloud data. + rpmlint output: OK rpmlint chunkd-*.rpm chunkd.spec chunkd.x86_64: W: incoherent-subsys /etc/rc.d/init.d/chunkd $prog chunkd-devel.x86_64: W: no-documentation 4 packages and 1 specfiles checked; 0 errors, 2 warnings. + package name satisfies the packaging naming guidelines + specfile name matches the package base name + package should satisfy packaging guidelines + license meets guidelines and is acceptable to Fedora + license matches the actual package license + %doc includes license file + spec file written in American English + spec file is legible ? upstream sources match sources in the srpm needs to update to the revision control packaging guidelines https://fedoraproject.org/wiki/Packaging/SourceURL#Using_Revision_Control + package successfully builds on at least one architecture tested using koji scratch build, if there is an upstream bug report for the PPC issues might be good to reference it. + BuildRequires list all build dependencies n/a %find_lang instead of %{_datadir}/locale/* + binary RPM with shared library files must call ldconfig in %post and %postun+ does not use Prefix: /usr + package owns all directories it creates + no duplicate files in %files + %defattr line + %clean contains rm -rf %{buildroot} + consistent use of macros + package must contain code or permissible content n/a large documentation files should go in -doc subpackage + files marked %doc should not affect package + header files should be in -devel n/a static libraries should be in -static + packages containing pkgconfig (.pc) files need 'Requires: pkgconfig' + libfoo.so must go in -devel + devel must require the fully versioned base + packages should not contain libtool .la files n/a packages containing GUI apps must include %{name}.desktop file + packages must not own files or directories owned by other packages + %install must start with rm -rf %{buildroot} etc. + filenames must be valid UTF-8 Optional: n/a if there is no license file, packager should query upstream n/a translations of description and summary for non-English languages, if available + reviewer should build the package in mock/koji + the package should build into binary RPMs on all supported architectures n/a review should test the package functions as described + scriptlets should be sane + pkgconfig files should go in -devel + shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or /usr/sbin
Created attachment 354282 [details] Updated chunkd spec file
Created attachment 354283 [details] Updated chunkd SRPM Updated per comments, most notably * greatly expanded %description * include instructions for recreating source tarball Successful koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1485476
Looks fine now. APPROVED!
New Package CVS Request ======================= Package Name: chunkd Short Description: Data storage service for cloud computing Owners: jgarzik zaitcev Branches: F-10 F-11 InitialCC:
CVS done.
Closing as its now in rawhide :-)